Anybody else problems with rev.725 ?

[Dittkol]

Hi @ all

Yesterday I updated the MM to 725 and it was running fine after I updated all the user functions,
but today in the morning the client was crashed. So I was wondering what happen.
OK the day goes on and then it started, I was running my normal scripts like every day "ks farming and mini games" but now the game client crashed every 20 min and i had to close the game over the task manager.

So after a 6-7 hours I was pissed after I couldn't find anything what is going wrong so i did a rollback to rev 723 and see there is no problem since 5 hours now.

So the question anybody else discovered something like this with rev.725 ??

[lisa]

Is there an error message on MM, if so what does it say?

Are you saying the game crashes or MM crashes?

Are you trying to use speedhack or swim hack in any of the Wp's ?


More details would help narrow down the issue.

[Dittkol]

Hi

There is no error message in the MM as the usual one when the game crashes.

The Game crashes not the MM, what i figured it crashes all the time short after he was going to sell out maybe it has something to do with the speed how fast it sells the Items now. I discovered big lags at the time he sells all.

I don't use a fly or swim hack in my "KS" script only the setwindow funktion is active.

Like I said rev.723 is running now for 12 hours thins I did the rollback last evening (without any problems).
I will go on with more testing today and put rev 724 on and let it run for a while to see if the error comes up. If not i will put on 725 to narrow at least down if rev. 724 or 725 causes the problem.
After this I will go through my script and take one function after the next out to see what happen and maybe find the problem.

[rock5]

Don't bother with 724. It is exactly the same as 725 except for 1 character, a "=" sign that fixed player:update() for dwarfs.

If you think it's when it's selling then I can offer a suggested fix. I already had this fix in mind in case anyone complained about the selling speed.

In player.lua around line 567 you will see the following lines

Code: Select all

				-- We didn't break? Then sell the item
				sellstring = sellstring .. "U("..slotitem.BagId..");" -- max length 7
				if #sellstring >= (254 - 7 - #sellendstring) then -- Can't fit more
					sellstring = sellstring .. sellendstring
					if RoMScript(sellstring) then
						yrest(100)
						hf_wesell = true;
						sellstring = sellstartstring -- Reset for more
					else
						break
					end
				end

Just comment out the 'if' statement that checks the string length.

Code: Select all

				-- We didn't break? Then sell the item
				sellstring = sellstring .. "U("..slotitem.BagId..");" -- max length 7
				--if #sellstring >= (254 - 7 - #sellendstring) then -- Can't fit more
					sellstring = sellstring .. sellendstring
					if RoMScript(sellstring) then
						yrest(100)
						hf_wesell = true;
						sellstring = sellstartstring -- Reset for more
					else
						break
					end
				--end

Don't forget to comment out the corresponding 'end' statement.

Let me know if you have trouble doing this and let me know how it performs for you. It should still be faster than the old selling method but obviously slower than the new method.

[Dittkol]

So now thanks rock for the tip but i couldn't find anything close to this lines in my player.lua sorry I don't know what is going on.
On the line what you said is something about "-- normal harvesting", then I used the search function even there is only one spot where comes something with "sell" and this is in line 3541.

Anyway I updated again to rev.725 and run my plane ks script without functions and anything and same thing after about 15-20 min. the game client crashes and no error code in MM.
So for now I will stick to rev.723 there works everything fine.

I'm only wondering nobody else here seems to have some problem like this because two of my buddies got the same problem.

Rock if you could tell me where i find this spot to do the adjustment in the player.lua would be great maybe I'm on a wrong way.

I think there is only one player.lua in "classes\player.lua" this is my understanding if I'm wrong please let me know.

[rock5]

Sorry, I meant inventory.lua. Are you able to confirm that it is always when selling that it crashes?

[Dittkol]

Ah Ok now it makes more sense.

What I can confirm is the crash comes about 30sec. till 1min after he sells the items but the first time after about 15-20 min. it makes so no sense

[rock5]

What I can confirm is the crash comes about 30sec. till 1min after he sells the items but the first time after about 15-20 min. it makes so no sense

It doesn't seem likely, then, that it is caused by the selling but if you try that change I suggested and it works then it has to be the cause. If it doesn't work then it's something else. If it's something else, it will help me to be able to find the problem if you can see any pattern to when it crashes.

[Dittkol]

Finally I'm back home and I did the changes to the inventory.lua after about 6 Hours running without a crash I almost would say this was the problem.

I hope so thanks to Rock.

[rock5]

It shouldn't be a problem to change it in my next commit as no one asked for faster selling, it's just something I decided to do.

So how did you like the speed? It should still be faster than it used to be because it used to do a RoMScript("StoreFrame:IsVisible()") with every sell. Now it does does both in one RoMScript.

BTW just to warn you, you will get a conflict the next time you update the bot as your changes will conlict with the changes I will make. So just remember you will have to do a Revert.

[Dittkol]

Hi
Thanks for the reminder to revert it before updating the next time.
I compared the speed with two MM windows side by side and it is a little bit faster but not much, so I don't see a real advantage in it but if we can save a sec or two I'm all for it .

Also I think I was to quick to confirme the bot is running fine after these changes, the thing is if I let it run with my knight it works perfect no crashes or anything else.
Now it comes if I run it with my mage I still got the same problem, my thoughts here are you wrote in your rev. notes there is something changed in the "click to cast option" if this could cause the problem because the only thing what is different in the scripts is if it is a mage it uses thunderstorm, now I get this option out of the script and try it again.

At this time I wasn't using you new option:

Code: Select all

<option name="FORCE_BETTER_AOE_TARGETING"  value="true" />

Let me know if it would make sense to post my scripts to have a look on it not I keep this post going for nothing if I got something wrong on my side what causes the problem.

Thanks

[rock5]

I compared the speed with two MM windows side by side and it is a little bit faster but not much, so I don't see a real advantage in it but if we can save a sec or two I'm all for it .

If you saw only a little bit of difference then it's probably because you have an older computer or a slower internet connection. I just watched my bot sell 6 full bags with the changed code and it took about 25-30 seconds. The 725 code, for me, takes about 10 seconds. But it's no use being faster if it crashes for some people.

my thoughts here are you wrote in your rev. notes there is something changed in the "click to cast option" if this could cause the problem because the only thing what is different in the scripts is if it is a mage it uses thunderstorm, now I get this option out of the script and try it again.

At this time I wasn't using you new option:

Code: Select all

<option name="FORCE_BETTER_AOE_TARGETING"  value="true" />

FORCE_BETTER_AOE_TARGETING is for overiding the default behaviour, which is "Use better targeting if mobs are level or else use old targeting". So if you want to try disabling the new targeting you need to set FORCE_BETTER_AOE_TARGETING to false so it always uses the old targeting. Let me know if that fixes your problem.

[Dittkol]

Hi I set it to "false" and no change I don't know anymore what I should try.
My computer is a I7 with 8Gb Ram and 1Gb Gpu I don't think it is the computer the Internet is a 16000 line.
At least I seen the problem now short before it crashes the FPS go's down to zero and this happens when the char cast's thunderstorm. Like I said I don't think it is a hardware or Internet problem because it's not happening with rev.723 runs for Hours without a problem.
I think i give up and stick for now to rev.723 and hope the problem is gone after the next update otherwise is the mm for me almost useless

I think the next step would be to redo my computer if there is nothing else screwed up what i don't believe because it runs just fine with the older version.

Rock thanks for your effort and help.

[rock5]

Sorry I haven't done more but I've been focusing on updating "fastlogin" which I'm nearly ready to post. With what you've told me I should be able to narrow down the problem. One thing I already noticed, looking at the code, is that even though you set FORCE_BETTER_AOE_TARGETING to false it still does most of the work for the better targeting even though it doesn't use it. There should be an initial check to see if it's false. If so then go straight to using the old targeting method. That alone would probably fix your issue. But the question is, why are you having problems with the new targeting? I'll make it my priority as soon as I post the new fastlogin.

By the way, does that mean you are not having an issue with the new autosell? I'd rather not change it if it's not necessary.

[Dittkol]

No hurry Rock finish up what you are working on.

Just to let you know, I disabled all AOE functions so it works only with Flame and Fireball now it seems to work at least it's not crashing.
Regarding the selling option I don't think this causes the problem on one of my computers it creates a big lag ate the time of selling but that's it.

If nobody else complain I don't think you have to change it.

[rock5]

Regarding the selling option I don't think this causes the problem on one of my computers it creates a big lag ate the time of selling but that's it.

I get a bit of freezing of the screen too but it still works a lot faster than it used to and seems to still be reliable. So I'll leave it as it is for now.

[BillDoorNZ]

love the new speed of selling BTW Rock!!!

[rock5]

No hurry Rock finish up what you are working on.

Just to let you know, I disabled all AOE functions so it works only with Flame and Fireball now it seems to work at least it's not crashing.

Sorry but I've been taking a bit of a break.


Try this. Around line 731 of pawn.lua you should see this.

Code: Select all

	-- The value this function needs to beat or match (if aoe center is this pawn)
	local countmobs = self:countMobs(aoerange, onlyaggro)

Just after that add,

Code: Select all

	if settings.profile.options.FORCE_BETTER_AOE_TARGETING == false then
		return countmobs, self.X, self.Z
	end

Re-enable your clicktocast skills and don't forget to set FORCE_BETTER_AOE_TARGETING to false in your profile. See if that works.

[Dittkol]

Hi I added the line you posted and tested it over night for 10 hours and it works fine.
I would say problem solved.

Thanks to you Rock.

P.S. One more question if I update the bot now in the future I have to change this all the time or not ?

[rock5]

Sure that provides a solution if you have a problem with the new targeting but it still bugs me that you have the problem in the first place.