My little helper

[rock5]

rock5 shouldn't this thread be moved to addons?

Yes it should.

Moved.

[j19861986]

When the lifepoints gets lower than 20, Assist healer move to target player and do Soul Source
then is this script correct??? (look below)

Code: Select all

			--change HP-settings to your needs
			if (20 > partymember[i].HP/partymember[i].MaxHP*100 and partymember[i].HP/partymember[i].MaxHP*100 > 20) then 
				player:target(partymember[i])
				if ( distance(player.X, player.Z, partymember[i].X, partymember[i].Z) > 100) then 
				player:moveTo(CWaypoint(partymember[i].X, partymember[i].Z), true)
				yrest(300)
				player:cast("PRIEST_SOUL_SOURCE") --change skills to your needs
				yrest(300)

Put code line

[rock5]

When the lifepoints gets lower than 20, Assist healer move to target player and do Soul Source
then is this script correct??? (look below)
--change HP-settings to your needs
if (20 > partymember.HP/partymember.MaxHP*100 and partymember.HP/partymember.MaxHP*100 > 20) then
player:target(partymember)
if ( distance(player.X, player.Z, partymember.X, partymember.Z) > 100) then
player:moveTo(CWaypoint(partymember.X, partymember.Z), true)
yrest(300)
player:cast("PRIEST_SOUL_SOURCE") --change skills to your needs
yrest(300)

How can the partymember hp be both below and above 20? I think you just want,

Code: Select all

			if 20 > partymember[i].HP/partymember[i].MaxHP*100 then 

Also it's in the forum rules that, when posting code in a post, that you have to surround it in 'code' tags like I did in the line above.

[swietlowka]

Short solution without buff communication

Code: Select all

		lootBodies()
		yrest(100)
		
		partyleader:update()
		if ( distance(player.X, player.Z, partyleader.X, partyleader.Z) > 200) then
				player:moveTo(CWaypoint(partyleader.X, partyleader.Z), true)
		end
		RoMScript("FollowUnit('party1');");

The buff communication is a nice idea though.

looking at this it seems ok, but hey, theres no partyleader so it gives an error ;d or maybe im not getting it well... should go to sleep about4h ago

[jduartedj]

I've been working on optimizing this script will post as soon as I have something concrete

[JackBlonder]

looking at this it seems ok, but hey, theres no partyleader so it gives an error ;d or maybe im not getting it well... should go to sleep about4h ago

try to add this at top of the wp-file

Code: Select all

	local partyleaderIndex
		local partyleader
		local partyleaderName
		local partyleaderObj

		partyleaderIndex = RoMScript("GetPartyLeaderIndex()")
		if partyleaderIndex~=nil then
			printf("Found partyleaderIndex: %d \n",partyleaderIndex)
			partyleaderName = RoMScript("UnitName('party"..partyleaderIndex.."')")
			printf("Partyleader: %s \n",partyleaderName)
			partyleaderObj = player:findNearestNameOrId(partyleaderName)
			partyleader = CPawn(partyleaderObj.Address)
		end

[sdude13]

I'm trying to change this script to merge with some rbassist functions.

I think I read it is not possible on some posts, but don't find a conrete answer for:
1. Is it possible to target a player not in your group/raid.
2. Can we get the HP of a targeted player (not in our group/raid)

[rock5]

I'm trying to change this script to merge with some rbassist functions.

I think I read it is not possible on some posts, but don't find a conrete answer for:
1. Is it possible to target a player not in your group/raid.
2. Can we get the HP of a targeted player (not in our group/raid)

Of course you can, they are pawns like any other.

[sdude13]

I'm trying to change this script to merge with some rbassist functions.

I think I read it is not possible on some posts, but don't find a conrete answer for:
1. Is it possible to target a player not in your group/raid.
2. Can we get the HP of a targeted player (not in our group/raid)

Of course you can, they are pawns like any other.

As I'm at work i don't have ROM here.

So I guess something like this will get the wanted player XXX into target of the bot:

Code: Select all

 local playertoassist= player:findNearestNameOrId("XXX")
 local targetplayer = CPawn(playertoassist.Address)

for the HP check:
targetplayer:update()
if (80 >targetplayer.HP/targetplayer.MaxHP*100 and targetplayer.HP/targetplayer.MaxHP*100 > 50) then 
				player:target(targetplayer)
		... some more code
end
RoMScript("FollowUnit(targetplayert);");

the player:findNearestNameOrId("XXX") returns NIL...
I don't know how I can get the char follow the other not being in the group

[rock5]

the player:findNearestNameOrId("XXX") returns NIL...

Maybe the player is out of range. You would need to check that it's not nil before continuing with the other commands or you will get an error.

I don't know how I can get the char follow the other not being in the group

You could just use player:moveInRange() whenever you get out of range. So you would need to continuously check if you are out of range.

[swietlowka]

the player:findNearestNameOrId("XXX") returns NIL...

Maybe the player is out of range. You would need to check that it's not nil before continuing with the other commands or you will get an error.

I don't know how I can get the char follow the other not being in the group

You could just use player:moveInRange() whenever you get out of range. So you would need to continuously check if you are out of range.

if u check if player:findNearestNameOrId("XXX") is nil and it gets true i'd add a loop to constantly check for it since from my experience it happends that one of the characters gets stuck or dies and when running u can unstuck it later or get from res point when having a good waypoint

[sdude13]

getting the player to assist seems to work now:

Code: Select all

repeat playertoassist = player:findNearestNameOrId("PlayerB") until playertoassist ~= nil
targetplayer = CPawn(playertoassist.Address)
print (targetplayer)

this prints the adress, but it changes every time (is this good ??)

trying
player:moveInRange(targetplayer)

after those lines (to get the char PLayerA follow the Player B) it quits with:
table: 03156F30
scripts/rom/classes/player.lua:1932: attempt to compare nil with number

[rock5]

trying
player:moveInRange(targetplayer)

scripts/rom/classes/player.lua:1932: attempt to compare nil with number

You need to specify a range, ie how close you want to get to the target;

Code: Select all

player:moveInRange(targetplayer,100)

[sdude13]

thx rock5

this seems to work! it follows now on the given distance.

however, when moving for some time
the bot stands still and gives :
"Stopping waypoint: Target acquired before moving.\n",

when moving closer to the char who should follow, it starts following again.

[rock5]

If you don't want it to look for targets while moving to the target then use

Code: Select all

player:moveInRange(targetplayer, 100, true)

[sdude13]

thx rock5 again. works as it should.

[JackBlonder]

I'm trying to improve it little bit but I have a weird problem.
Everytime the group is in battle and the leader is moving away from healer, the healer doesn't move in range of the leader.
BUT, when leaving combat the healer moves to his leader
Here's my current code

Code: Select all

<?xml version="1.0" encoding="utf-8"?><waypoints>
	<onLoad>
		local maxBattleDistToLeader = 50	--Change to your needs 
		local maxDistToLeader = 250	--Change to your needs (for example if you want use lootBodies)
		local partymember={}
		local partymemberName={}
		local partymemberObj={}
		local partyleaderIndex
		local partyleader
		local partyleaderName
		local partyleaderObj
		local noofpartymembers
		local i

		repeat buff_regen=RoMScript("TEXT('Sys500469_name')"); yrest(500) until buff_regen --Get local name of regen buff

		
--********************************************************
--get all partymembers
--********************************************************
	if RoMScript("UnitExists('party1')") then
	
		partyleaderIndex = RoMScript("GetPartyLeaderIndex()")
		if partyleaderIndex~=nil then
			printf("Found partyleaderIndex: %d \n",partyleaderIndex)
			partyleaderName = RoMScript("UnitName('party"..partyleaderIndex.."')")
			printf("Partyleader: %s \n",partyleaderName)
			partyleaderObj = player:findNearestNameOrId(partyleaderName)
			partyleader = CPawn(partyleaderObj.Address)
		end
					
	
		table.insert(partymemberName, RoMScript("UnitName('player')"))

		i = 1
		while not(i >= 7 ) do
			if RoMScript("UnitIsPlayer('party"..i.."');") then
				table.insert(partymemberName,i+1, RoMScript("UnitName('party"..i.."')"))

			end
			i = i + 1

		end
		
		--show table
		for i,v in ipairs(partymemberName) do print(i,v) end

		noofpartymembers = #partymemberName
		--print(noofpartymembers)
		
		for i,v in ipairs(partymemberName) do
			table.insert(partymemberObj,i,player:findNearestNameOrId(partymemberName[i]))
			table.insert(partymember,i,CPawn(partymemberObj[i].Address))
		end
		
		--****DEBUGGING
		--for i,v in ipairs(partymemberObj) do print(i,v) end
		--for i,v in ipairs(partymember) do print(i,v) end

		--*************
	end
	
--********************************************************************
--Look at partymember health and return partymember with lowest health 	
--********************************************************************	
	function get_LeastHpPlayer(party)
		
		local minHpPlayer=player
		local i=1

		for i,v in ipairs(party) do
			party[i]:update()
			if (minHpPlayer.HP/minHpPlayer.MaxHP*100 > party[i].HP/party[i].MaxHP*100) then
				minHpPlayer=party[i]
			end
		end
		
		return minHpPlayer
	end
			
--********************************************************
--Main loop	
--********************************************************
	while(true) do
		player:update()
		partyleader:update()
		if (player.Battling and distance(player.X, player.Z, partyleader.X, partyleader.Z) > maxBattleDistToLeader) then
				player:moveInRange(partyleader, maxBattleDistToLeader, true)
		elseif (not player.Battling and distance(player.X, player.Z, partyleader.X, partyleader.Z) > maxDistToLeader) then
				player:moveInRange(partyleader, maxBattleDistToLeader, true)
		else
			local healTarget
			healTarget = get_LeastHpPlayer(partymember)
			
			if (90 > healTarget.HP/healTarget.MaxHP*100 and 
				healTarget.HP/healTarget.MaxHP*100 > 70 and 
				not healTarget:hasBuff(buff_regen) ) then
					player:target(healTarget)
					player:cast("PRIEST_REGENERATE")
			elseif (70 > healTarget.HP/healTarget.MaxHP*100 and 
					healTarget.HP/healTarget.MaxHP*100 > 50) then
						player:target(healTarget)
						player:cast("PRIEST_URGENT_HEAL")
			elseif (50 > healTarget.HP/healTarget.MaxHP*100) then
						player:target(healTarget)
						player:cast("PRIEST_HEAL")
			end
		end
		yrest(1000)
	end

	</onLoad>
</waypoints>

Anyone has a good idea on this?

[rock5]

It's pretty clear, the first thing you check is if it is in battle and the distance is too far, then move closer. I'm not sure why it wouldn't do it. Maybe it is getting caught up doing something else? I think it's important to see what it's doing when it doesn't follow the leader.

[JackBlonder]

I'll try to get some more information after work.

[Edit]
Did some testing.
It's definitely stick here while the party is in battle. But it just stands/doesn't move.
I have no idea why.
Is there any distance check (to target or anything else) when player is in battle in rombots routine that hinders the player to move?

Code: Select all

		if (player.Battling and distance(player.X, player.Z, partyleader.X, partyleader.Z) > maxBattleDistToLeader) then
				printf("in battle\n")  --added for debugging
				player:moveInRange(partyleader, maxBattleDistToLeader, true)

[lisa]

Played around with this today for a bit, it doesn't seem to heal while in combat for some reason. Did anyone look to find out why?