Page 2 of 4

Re: Problem with auto login on next char

Posted: Mon Aug 11, 2014 8:34 am
by wiedzmin97

Code: Select all

Loaded waypoint path heffner.xml
No return path with default naming heffner_return.xml found.
We use the normal waypoint path heffner.xml now.
Moving to waypoint #1, (-7134, -3952)
LoginNextChar
Changing to character 1 account 62.
Player address changed: 0x43F25F00
Its seems that it gets stuck before player update.

Re: Problem with auto login on next char

Posted: Mon Aug 11, 2014 8:58 am
by rock5
Ok then. The last message about the character address changing comes from a player:update(). LoginNextChar uses ChangeChar and at the end of ChangeChar there is a player:update() and this line

Code: Select all

CurrentLoginServer = RoMScript ("GetCurrentRealm()")
So it's getting stuck in the player:update() or when running that RoMScript.

Here is a version of player.lua that prints some numbers to help narrow down the location of the bug. Please try it and show me the printout when it gets stuck.

-- Obsolete file removed --

Re: Problem with auto login on next char

Posted: Mon Aug 11, 2014 9:21 am
by wiedzmin97

Code: Select all

Loaded waypoint path heffner.xml
No return path with default naming heffner_return.xml found.
We use the normal waypoint path heffner.xml now.
Moving to waypoint #1, (-7134, -3952)
LoginNextChar
Changing to character 1 account 62.
Player address changed: 0x422B6400
1
2

Re: Problem with auto login on next char

Posted: Mon Aug 11, 2014 10:53 am
by rock5
Between 2 and 3 there are no loops but 2 functions it could get stuck in. I don't think it could be settings.loadSkillSet so it's most likely the

Code: Select all

RoMCode
.

The RoMCode basically just uses the RoMScript function. The RoMScript function is huge so I'll have to add a few prints to narrow it down further.

First revert the changes you've already done in player.lua and then use this version of functions.lua that has print messages in the RoMScript function. Again, when it gets stuck copy the output here. If there is a print message in the loop that it gets stuck at then it will repeatedly print. Just stop it then copy the output here.

-- Obsolete file removed --

Re: Problem with auto login on next char

Posted: Mon Aug 11, 2014 11:04 am
by wiedzmin97

Code: Select all

Loaded waypoint path heffner.xml
No return path with default naming heffner_return.xml found.
We use the normal waypoint path heffner.xml now.
1       LogID
2
4       154140672
5       CommandMacro    1
6       false   116
7
8       true    61
9       61
1       CHARACTER_SELECT.selectedIndex
2
4       154140672
5       CommandMacro    1
6       false   116
7
8       true    1
9       1
1       GetCurrentRealm()
2
4       154140672
5       CommandMacro    1
6       false   116
7
8       true    Angel City
9       Angel City
Moving to waypoint #1, (-7134, -3952)
Use MACRO: PRIEST_GRACE_OF_LIFE1        } CastSpellByName("Grace of Life"); if t
ype(a)~="table" then a={a} end z={
2
4       154140672
5       CommandMacro    1
6       false   116
7
8       true
9
=>   <UNKNOWN> (0/1000)
LoginNextChar
1       LogID
2
4       154140672
5       CommandMacro    1
6       false   116
7
8       true    61
9       61
1       CHARACTER_SELECT.selectedIndex
2
4       154140672
5       CommandMacro    1
6       false   116
7
8       true    1
9       1
1       fastLoginNumChars
2
4       154140672
5       CommandMacro    1
6       false   116
7
8       true    1
9       1
1       CharsLoadedCount
2
4       154140672
5       CommandMacro    1
6       false   116
7
8       true    16
9       16
Changing to character 1 account 62.
Player address changed: 0x38050000

Re: Problem with auto login on next char

Posted: Mon Aug 11, 2014 11:43 am
by rock5
There are no print messages after the address change. That means it never reached the RoMCode after it. Maybe it is the settings.loadSkillSet. I can't really see where it would get stuck in that function. This is getting frustrating. Seeing as settings.loadSkillSet has to do with the profile, have you tried using the default profile?

Re: Problem with auto login on next char

Posted: Mon Aug 11, 2014 11:56 am
by wiedzmin97
yea, still the same situation ;//

Re: Problem with auto login on next char

Posted: Mon Aug 11, 2014 12:25 pm
by wiedzmin97
I have tried to download clean MicroMacro and RomBot, i have installed it (without updating via SVN).
And now everything is working good...

@edit
when i updated it to newest revision, it does not work again...

Re: Problem with auto login on next char

Posted: Mon Aug 11, 2014 12:30 pm
by rock5
I guess we'll have to try some print messages in settings.loadSkillSet. Revert functions.lua and then try this file.

-- Obsolete file removed --

Re: Problem with auto login on next char

Posted: Mon Aug 11, 2014 12:39 pm
by wiedzmin97

Code: Select all

Loaded waypoint path heffner.xml
No return path with default naming heffner_return.xml found.
We use the normal waypoint path heffner.xml now.
Moving to waypoint #1, (-7134, -3952)
LoginNextChar
Changing to character 1 account 62.
Player address changed: 0x29A73700
1       6
2
3
4       setupmacro
5

Re: Problem with auto login on next char

Posted: Mon Aug 11, 2014 1:07 pm
by rock5
Ok, that narrows it down to the GetSkillBookData function. Damn another function. Will we ever narrow it down to 1 line of code? Grrr...

Revert settings.lua and try this version of functions.lua.

-- Obsolete file removed --

Re: Problem with auto login on next char

Posted: Mon Aug 11, 2014 1:15 pm
by wiedzmin97

Code: Select all

Loaded waypoint path heffner.xml
No return path with default naming heffner_return.xml found.
We use the normal waypoint path heffner.xml now.
Moving to waypoint #1, (-7134, -3952)
LoginNextChar
Changing to character 1 account 62.
Player address changed: 0x29A73C00
1       2       3       4
2
3
3.1     2       608     76
3.2
3.3     490148
3.4
3.2
3.3     490151
3.4
3.2

Re: Problem with auto login on next char

Posted: Mon Aug 11, 2014 1:31 pm
by rock5
What's the 3rd skill on the second tab of your skills (when you press K)? Do you only get stuck with knights?

Re: Problem with auto login on next char

Posted: Mon Aug 11, 2014 1:37 pm
by wiedzmin97
Not only with knights, i have just all chars (different classes) with 10-20 lvls.
3rd skill is : Punishment

On the next char with class Scout i have something that:

Code: Select all

Loaded waypoint path heffner.xml
No return path with default naming heffner_return.xml found.
We use the normal waypoint path heffner.xml now.
Moving to waypoint #1, (-7134, -3952)
Use MACRO: KNIGHT_ENHANCED_ARMO=>   <UNKNOWN> (0/1000)
Use MACRO: KNIGHT_HOLY_POWER_EX=>   Dpstwo (897/897)
LoginNextChar
Changing to character 1 account 63.
Player address changed: 0x49939100
1       2       3       4
2
3
3.1     2       684     76
3.2

And also it gets stuck. When i will open second tab of my skills, its starting work :D

Re: Problem with auto login on next char

Posted: Mon Aug 11, 2014 2:31 pm
by rock5
I did some changes to GetIdName recently and I might have introduced a bug. The reason it works when you open the skills is because there is a step in GetIdName where it executes a command to force information about an id to appear in memory. Obviously this is not working. When you open the skills it also makes the id info appear in memory.

Revert the last file and try this one. This one will print a LOT of print outs.


Wow, look at the time. It's bed time for me. I'll check back tomorrow.

-- Obsolete file removed --

Re: Problem with auto login on next char

Posted: Mon Aug 11, 2014 2:46 pm
by wiedzmin97

Code: Select all

Loaded waypoint path heffner.xml
No return path with default naming heffner_return.xml found.
We use the normal waypoint path heffner.xml now.
Moving to waypoint #1, (-7134, -3952)
1 490290
4       266165600       55321664
5       490290  490290
6       1245427712
7       1245427712
1 497955
4       250319936       55321664
5       512047  497955
4       251032320       55321664
5       224096  497955
4       251949824       55321664
5       232288  497955
4       266664768       55321664
5       493123  497955
4       264942304       55321664
5       503123  497955
4       264745696       55321664
5       501075  497955
4       266926912       55321664
5       495171  497955
4       267123520       55321664
5       497219  497955
4       263926496       55321664
5       500051  497955
4       267090752       55321664
5       498243  497955
4       267107136       55321664
5       497731  497955
4       267098944       55321664
5       497987  497955
4       267103040       55321664
5       497859  497955
4       267100992       55321664
5       497923  497955
4       267099968       55321664
5       497955  497955
6       0
7       1021185024
1 490290
4       266165600       55321664
5       490290  490290
6       1245427712
7       1245427712
1 497956
4       250319936       55321664
5       512047  497956
4       251032320       55321664
5       224096  497956
4       251949824       55321664
5       232288  497956
4       266664768       55321664
5       493123  497956
4       264942304       55321664
5       503123  497956
4       264745696       55321664
5       501075  497956
4       266926912       55321664
5       495171  497956
4       267123520       55321664
5       497219  497956
4       263926496       55321664
5       500051  497956
4       267090752       55321664
5       498243  497956
4       267107136       55321664
5       497731  497956
4       267098944       55321664
5       497987  497956
4       267103040       55321664
5       497859  497956
4       267100992       55321664
5       497923  497956
4       267099968       55321664
5       497955  497956
4       267099456       55321664
5       497971  497956
4       267099712       55321664
5       497963  497956
4       267099840       55321664
5       497959  497956
4       267099904       55321664
5       497957  497956
4       267099936       55321664
5       497956  497956
6       0
7       1021221888
1 500517
4       264763552       55321664
5       500517  500517
6       941948928
7       941948928
1 507217
4       265335584       55321664
5       507217  507217
6       968948736
7       968948736
1 622704
4       265749856       55321664
5       622704  622704
6       968947712
7       968947712
1 500517
4       264763552       55321664
5       500517  500517
6       941948928
7       941948928
1 490290
4       266165600       55321664
5       490290  490290
6       1245427712
7       1245427712
1 497955
4       267099968       55321664
5       497955  497955
6       1021185024
7       1021185024
1 490290
4       266165600       55321664
5       490290  490290
6       1245427712
7       1245427712
1 497956
4       267099936       55321664
5       497956  497956
6       1021221888
7       1021221888
1 500517
4       264763552       55321664
5       500517  500517
6       941948928
7       941948928
1 507217
4       265335584       55321664
5       507217  507217
6       968948736
7       968948736
1 622704
4       265749856       55321664
5       622704  622704
6       968947712
7       968947712
1 500517
4       264763552       55321664
5       500517  500517
6       941948928
7       941948928
LoginNextChar
Changing to character 1 account 62.
Player address changed: 0x2B4A4600
1 500141
4       250319936       55321664
5       512047  500141
4       251032320       55321664
5       224096  500141
4       251949824       55321664
5       232288  500141
4       266664768       55321664
5       493123  500141
4       264942304       55321664
5       503123  500141
4       264745696       55321664
5       501075  500141
4       266926912       55321664
5       495171  500141
4       267123520       55321664
5       497219  500141
4       263926496       55321664
5       500051  500141
4       264762080       55321664
5       500563  500141
4       263918304       55321664
5       500307  500141
4       263922400       55321664
5       500179  500141
4       263924448       55321664
5       500115  500141
4       263923424       55321664
5       500147  500141
4       263923936       55321664
5       500131  500141
4       263923680       55321664
5       500139  500141
4       263923552       55321664
5       500143  500141
4       263923616       55321664
5       500141  500141
6       1210924032
7       1210924032
1 622704
4       265749856       55321664
5       622704  622704
6       968947712
7       968947712
1 490148
4       250319936       55321664
5       512047  490148
4       251032320       55321664
5       224096  490148
4       251949824       55321664
5       232288  490148
4       266664768       55321664
5       493123  490148
4       259730304       55321664
5       242306  490148
4       293973024       55321664
5       423148  490148
4       266468160       55321664
5       491075  490148
4       294235168       55321664
5       425196  490148
4       266173248       55321664
5       490051  490148
4       266156864       55321664
5       490563  490148
4       266165056       55321664
5       490307  490148
4       266169152       55321664
5       490179  490148
4       266171200       55321664
5       490115  490148
4       266170176       55321664
5       490147  490148
4       266169664       55321664
5       490163  490148
4       266169920       55321664
5       490155  490148
4       266170048       55321664
5       490151  490148
4       266170112       55321664
5       490149  490148
4       266170144       55321664
5       490148  490148
6       515622912
7       515622912
4       266170144       55321664
5       490148  490148
6       515622912
7       515622912
1 490151
4       266170048       55321664
5       490151  490151
6       515620864
7       515620864
4       266170048       55321664
5       490151  490151
6       515620864
7       515620864
1 490159
4       250319936       55321664
5       512047  490159
4       251032320       55321664
5       224096  490159
4       251949824       55321664
5       232288  490159
4       266664768       55321664
5       493123  490159
4       259730304       55321664
5       242306  490159
4       293973024       55321664
5       423148  490159
4       266468160       55321664
5       491075  490159
4       294235168       55321664
5       425196  490159
4       266173248       55321664
5       490051  490159
4       266156864       55321664
5       490563  490159
4       266165056       55321664
5       490307  490159
4       266169152       55321664
5       490179  490159
4       266171200       55321664
5       490115  490159
4       266170176       55321664
5       490147  490159
4       266169664       55321664
5       490163  490159
4       266169920       55321664
5       490155  490159
4       266169792       55321664
5       490159  490159
6       0
Yea its also time for bed :D wow its for me really "black magic" :D when i see these all digits... ^^

Re: Problem with auto login on next char

Posted: Mon Aug 11, 2014 3:03 pm
by rock5
Ok last post before bed.

So we've narrowed it down to this code.

Code: Select all

					SlashCommand("/script GetCraftRequestItem(".. IdToFind ..",-1)")
					-- Wait until data address appears
					repeat
						yrest(5)
						address = memoryReadUInt( proc, AddresslineTree[addressline][4] + 0x8)
					until address ~= 0
It's obviously getting stuck in the loop waiting for the address to appear in memory after the SlashCommand but for some reason it didn't work. I'm not sure yet what to make of this. I'll sleep on it and get back to you tomorrow.

Re: Problem with auto login on next char

Posted: Tue Aug 12, 2014 1:27 am
by rock5
Ok I've come up with 2 solutions.

Firstly one of the changes I made to memorytable.lua recently was to use SlashCommand instead of RoMScript in that bit of code I posted because SlashCommand is faster. Besides being faster it is missing the checks that RoMScript has to see if the Command and Result macro have moved as happens when you change character. So the first fix I did was to copy those checks from RoMScript to SlashCommand.

Next I added a timer to the waiting loop to have it try again if it fails. If the previous fix fixes it I probably wont include this fix when I commit.

This time there are 2 files, functions.lua which has the extra checks added to SlashCommand, and memorytable.lua which has the timer added to the wait. Each fix has 1 print message that should trigger if 1 of those fixes is used so I'd like to know which one gets printed. If the bot doesn't get stuck stop it just after it finished changing character and copy the output here.

I'm crossing my fingers.

Re: Problem with auto login on next char

Posted: Tue Aug 12, 2014 8:58 am
by wiedzmin97

Code: Select all

Loaded waypoint path heffner.xml
No return path with default naming heffner_return.xml found.
We use the normal waypoint path heffner.xml now.
Moving to waypoint #1, (-7134, -3952)
LoginNextChar
Changing to character 1 account 62.
Player address changed: 0x38166900
Trying again in GetItemAddress
No ranged skills specified in profile; Turning COMBAT_RANGED_PULL off.
Maximum range of range attack skills is less than COMBAT_DISTANCE 200. Reducing
COMBAT_DISTANCE setting to 50.
player update
loadProfile
No ranged skills specified in profile; Turning COMBAT_RANGED_PULL off.
Maximum range of range attack skills is less than COMBAT_DISTANCE 200. Reducing
COMBAT_DISTANCE setting to 50.
We read the hotkey settings from your bindings.txt file C:\Users\XXX\Moje doku
menty\Runes of Magic\bindings.txt instead of using the settings.xml file.
Loading profile Dpstwo.xml
Testing 'ingamefunctions' macro. If it gets stuck here, please update the 'ingam
efunctions' by copying the 'ingamefunctions' folder from 'rom/devtools' to the g
ames 'interface/addons' folder.
MACRO Test: ok
No ranged skills specified in profile; Turning COMBAT_RANGED_PULL off.
Maximum range of range attack skills is less than COMBAT_DISTANCE 200. Reducing
COMBAT_DISTANCE setting to 50.
loadPaths
Loaded waypoint path heffner.xml
No return path with default naming heffner_return.xml found.
We use the normal waypoint path heffner.xml now.
Moving to waypoint #1, (-7134, -3952)
Use MACRO: KNIGHT_ENHANCED_ARMO=>   <UNKNOWN> (0/1000)
Use MACRO: KNIGHT_HOLY_POWER_EXPaused. (Delete) to continue, (CTRL+L) exit to sh
ell, (CTRL+C) quit
So, i see only one new printed message:

Code: Select all

Trying again in GetItemAddress 

Re: Problem with auto login on next char

Posted: Tue Aug 12, 2014 10:02 am
by rock5
Ok, thanks. I was hoping it wouldn't be that one but anyway...

Thanks for your patience while we worked this out. Hopefully it will help avoid future users having the same issue. The files you have now should do you until I commit. When I do you'll probably have to do a revert after you update to clear any conflicts.