Page 2 of 12
Re: Eggs
Posted: Sat Jul 03, 2010 3:24 pm
by somberland
Did I have to setup my camera to a specific type/angel? if he runs into the house for the chickens he can't see them and so can't click on them
same with the cornsack
Edit:// btw somewhere I read that I don't have the game to be open (windows-focus) to harvest, but it still say's that I can't harvest without window-focus (updatet to newest svn-version.
Re: Eggs
Posted: Sat Jul 03, 2010 4:05 pm
by VoidMain
wizzyslo wrote:ATM bot can easy miss egg and i wont to fix that. I wont to do bot that doing prfect never missed egg, get all chickens and now you are telling me that i doing bot that dont pick eggs are you stupid or what? And whay are you telling me that i'm doing bot that don't do anything sorry you are talking as idiot.
First of all, you don't need to insult, second, the idiot are you, i'm not using and old versión to harvest, that's just plain stupid, third, fuck off, asshole, i was trying to help you, a really difficult thing to do with the horrible english you use to write your sentences.
Re: Eggs
Posted: Sat Jul 03, 2010 4:14 pm
by rock5
Nebojsha wrote:another thing, each time chicken lays down egg, if u click it 2 times fast enough u get 2 eggs, is this possible with bot?
I don't believe you can get 2 eggs from a chicken laying once. I think what might have happened to you is you clicked the chicken once but failed to pick up the egg then you fed the chicken again and when you went and clicked it again in the chicken coop you ended up with 2 eggs.
If I'm wrong, please explain better how to get 2 eggs because I couldn't do it.
Re: Eggs
Posted: Sat Jul 03, 2010 4:24 pm
by Nebojsha
so egg shows, u click it and as soon as you finish taking it u click again before it dissapears. Works 100% on all eggs, including golden
Re: Eggs
Posted: Sat Jul 03, 2010 4:26 pm
by somberland
after feeding the chicken and walk to it to cheer it, it puts down the egg, just klick as long as your coursor stays with that "u can use that shit"-style, so u get 1 normal and while it disapears the second one.
Re: Eggs
Posted: Sat Jul 03, 2010 4:52 pm
by rock5
Nebojsha wrote:so egg shows, u click it and as soon as you finish taking it u click again before it dissapears. Works 100% on all eggs, including golden
Hey yeh, you're right. Try this;
player:harvest(112958) yrest(1900) sendMacro("UseSkill(1,1)")
Re: Eggs
Posted: Sat Jul 03, 2010 6:42 pm
by wizzyslo
I done my waypoing but still not good. Need to rapair lot's of things.
Code: Select all
<?xml version="1.0" encoding="utf-8"?><waypoints>
<!-- # 1 --><waypoint x="4029" z="3168"> </waypoint>
<!-- # 2 --><waypoint x="4079" z="3172"> </waypoint>
<!-- # 3 --><waypoint x="4110" z="3121"> </waypoint>
<!-- # 4 --><waypoint x="4114" z="3113">
player:harvest(112956)
if player:harvest(112956) then
yrest(8000);
end
player:harvest(112956)
if player:harvest(112956) then
yrest(8000);
end
player:harvest(112956)
if player:harvest(112956) then
yrest(8000);
end
</waypoint>
<!-- # 5 --><waypoint x="4079" z="3170"> </waypoint>
<!-- # 6 --><waypoint x="4040" z="3162"> </waypoint>
<!-- # 7 --><waypoint x="3950" z="3004"> </waypoint>
<!-- # 9 --><waypoint x="3936" z="2968">
player:harvest(112956);
if player:harvest(112956) then
yrest(8000)
end
player:harvest(112956);
if player:harvest(112956) then
yrest(8000)
end
player:harvest(112956);
if player:harvest(112956) then
yrest(8000)
end
</waypoint>
<waypoint x="3935" z="3039">
player:harvest(112955)
if player:harvest(112955) then
yrest(6000)
end
player:harvest(112955)
if player:harvest(112955) then
yrest(6000)
end
player:harvest(112955)
if player:harvest(112955) then
yrest(6000)
end
</waypoint>
<waypoint x="3947" z="3107">
player:harvest(112955)
if player:harvest(112955) then
yrest(6000)
end
player:harvest(112955)
if player:harvest(112955) then
yrest(6000)
end
player:harvest(112955)
if player:harvest(112955) then
yrest(6000)
end
</waypoint>
<waypoint x="3958" z="3136">
player:harvest(112955)
if player:harvest(112955) then
yrest(6000)
end
player:harvest(112955)
if player:harvest(112955) then
yrest(6000)
end
player:harvest(112955)
if player:harvest(112955) then
yrest(6000)
end
</waypoint>
<!-- # 1 --><waypoint x="3946" z="3264">
yrest(1000)
player:harvest(112955)
yrest(500)
if player:harvest(112955) then
yrest(5000)
end
player:harvest(112958)
if player:harvest(112958) then
yrest(1200)
end
player:harvest(112958) if player:harvest(112958) then yrest(50) end
player:harvest(112958) if player:harvest(112958) then yrest(50) end
player:harvest(112958) if player:harvest(112958) then yrest(50) end
player:harvest(112958) if player:harvest(112958) then yrest(50) end
player:harvest(112958) if player:harvest(112958) then yrest(50) end
player:harvest(112958) if player:harvest(112958) then yrest(2000) end
player:harvest(114931)
if player:harvest(114931) then
yrest(1200)
end
player:harvest(114931) if player:harvest(114931) then yrest(50) end
player:harvest(114931) if player:harvest(114931) then yrest(50) end
player:harvest(114931) if player:harvest(114931) then yrest(50) end
player:harvest(114931) if player:harvest(114931) then yrest(50) end
player:harvest(114931) if player:harvest(114931) then yrest(50) end
player:harvest(114931) if player:harvest(114931) then yrest(2000) end
</waypoint>
<!-- # 2 --><waypoint x="3929" z="3265">
yrest(1000)
player:harvest(112955)
yrest(500)
if player:harvest(112955) then
yrest(5000)
end
player:harvest(112958)
if player:harvest(112958) then
yrest(1200)
end
player:harvest(112958) if player:harvest(112958) then yrest(50) end
player:harvest(112958) if player:harvest(112958) then yrest(50) end
player:harvest(112958) if player:harvest(112958) then yrest(50) end
player:harvest(112958) if player:harvest(112958) then yrest(50) end
player:harvest(112958) if player:harvest(112958) then yrest(50) end
player:harvest(112958) if player:harvest(112958) then yrest(2000) end
player:harvest(114931)
if player:harvest(114931) then
yrest(1200)
end
player:harvest(114931) if player:harvest(114931) then yrest(50) end
player:harvest(114931) if player:harvest(114931) then yrest(50) end
player:harvest(114931) if player:harvest(114931) then yrest(50) end
player:harvest(114931) if player:harvest(114931) then yrest(50) end
player:harvest(114931) if player:harvest(114931) then yrest(50) end
player:harvest(114931) if player:harvest(114931) then yrest(2000) end
</waypoint>
<!-- # 2 --><waypoint x="3920" z="3265">
yrest(1000)
player:harvest(112955)
yrest(500)
if player:harvest(112955) then
yrest(5000)
end
player:harvest(112955)
yrest(500)
if player:harvest(112955) then
yrest(5000)
end
player:harvest(112958)
if player:harvest(112958) then
yrest(1200)
end
player:harvest(112958) if player:harvest(112958) then yrest(50) end
player:harvest(112958) if player:harvest(112958) then yrest(50) end
player:harvest(112958) if player:harvest(112958) then yrest(50) end
player:harvest(112958) if player:harvest(112958) then yrest(50) end
player:harvest(112958) if player:harvest(112958) then yrest(50) end
player:harvest(112958) if player:harvest(112958) then yrest(2000) end
player:harvest(114931)
if player:harvest(114931) then
yrest(1200)
end
player:harvest(114931) if player:harvest(114931) then yrest(50) end
player:harvest(114931) if player:harvest(114931) then yrest(50) end
player:harvest(114931) if player:harvest(114931) then yrest(50) end
player:harvest(114931) if player:harvest(114931) then yrest(50) end
player:harvest(114931) if player:harvest(114931) then yrest(50) end
player:harvest(114931) if player:harvest(114931) then yrest(2000) end
</waypoint>
<!-- # 4 --><waypoint x="3912" z="3199"> </waypoint>
</waypoints>
If waypoing don't works do this:
rock5 wrote:
Insert at line 95 of player.lua, just before "self:update();" the following;
Code: Select all
if _id then -- The rest is not needed if not resource node
lastHarvestedNodeAddr = closestHarvestable.Address;
return true
end
Re: Eggs
Posted: Sat Jul 03, 2010 7:21 pm
by somberland
The fist "self:update();" apears on my player.lua at line 139
Code: Select all
137 while( foundHarvestNode ~= 0 and nodeMouseX and nodeMouseY ) do
138 ---maybe the right place???---
139 self:update();
140
141 if( self.Battling ) then -- we get aggro, stop harvesting
142 keyboardRelease(key.VK_SHIFT);
143 if( self.Returning ) then -- set wp one back to harverst wp
144 __RPL:backward(); -- again after the fight
145 else
146 __WPL:backward();
147 end;
148 break;
149 end;
Thanks for the Waypoints, I will try it
Edit:// I don't know why, but it looks like that the Cursor flows too fast over the screen so he can't catch the chicken (around 1/6 he get one).
Re: Eggs
Posted: Sat Jul 03, 2010 9:02 pm
by Binafus
139 is my first player update as well.
Line 90 to 101 in my player.lua
Code: Select all
if( mousePawn.Address ~= 0
and distance(self.X, self.Z, mousePawn.X, mousePawn.Z) < 150
and _id == mousePawn.Id ) then
return mousePawn.Address, mx, my, mousePawn.Id;
end
-- normal harvesting
if( mousePawn.Address ~= 0 and mousePawn.Type == PT_NODE
and distance(self.X, self.Z, mousePawn.X, mousePawn.Z) < 150
and database.nodes[mousePawn.Id] ) then
return mousePawn.Address, mx, my, mousePawn.Id;
end
You can slow your Cursor down by adding the following line in your player config, the higher the number the slower it will move.
<option name="HARVEST_SCAN_YREST" value="8" />
4
Re: Eggs
Posted: Sun Jul 04, 2010 12:12 am
by VoidMain
Code: Select all
<?xml version="1.0" encoding="utf-8"?><waypoints type="TRAVEL">
<waypoint x="3934" z="2995">while player:harvest(112956) do yrest(2000); end;</waypoint>
<waypoint x="3935" z="3039">while player:harvest(112955) do yrest(3500);player:clearTarget(); end;</waypoint>
<waypoint x="3947" z="3107">while player:harvest(112955) do yrest(3500);player:clearTarget(); end;</waypoint>
<waypoint x="3958" z="3136">while player:harvest(112955) do yrest(5000);player:clearTarget(); end;</waypoint>
<waypoint x="3924" z="3214"> </waypoint>
<waypoint x="3914" z="3257">
while player:harvest(112955) do
yrest(8000);
end
while (player:harvest(112958)) do
yrest(1900);
sendMacro("UseSkill(1,1)");
end;
while player:harvest(114931) do
yrest(10);
end
</waypoint>
<waypoint x="3951" z="3206"> </waypoint>
<waypoint x="3938" z="3066"> </waypoint>
<waypoint x="3936" z="3035"> </waypoint>
</waypoints>
This waypoint works great with the fix sugested by rock5, never misses a chicken or an egg and also harvests 2 eggs of each one...
The check for white eggs is not on a while because it hangs the client, but this way it works great, i got 700 white eggs and 56 golden eggs this way.
Note: This is made to work with the newest version of harvesting. I still don´t get why some ppl is using an old version...
Re: Eggs
Posted: Sun Jul 04, 2010 12:44 am
by rock5
wizzyslo wrote:I done my waypoing but still not good. Need to rapair lot's of things.
You misunderstood what it means when a function returns true. If a function returns true, it still executed. So this code;
Code: Select all
player:harvest(112956)
if player:harvest(112956) then
yrest(8000);
end
Does this;
Execute harvest; -- ignores returned value
if (execute harvest again) returns true then
yrest(8000)
So you see, this executes it twice which is not what you intended. You need to remove the first harvest.
So it should be;
Code: Select all
if player:harvest(112956) then
yrest(8000);
end
if player:harvest(112956) then
yrest(8000);
end
if player:harvest(112956) then
yrest(8000);
end
Even better, try this;
Code: Select all
while player:harvest(112956) do
yrest(8000);
end
This will just keep harvesting until there are non left.
Re: Eggs
Posted: Sun Jul 04, 2010 12:47 am
by rock5
somberland wrote:The fist "self:update();" apears on my player.lua at line 139
Thanks for the Waypoints, I will try it
Edit:// I don't know why, but it looks like that the Cursor flows too fast over the screen so he can't catch the chicken (around 1/6 he get one).
That is because you are using an older bot. Update to the latest SVN revision. It doesn't use the mouse to harvest.
Re: Eggs
Posted: Sun Jul 04, 2010 12:57 am
by rock5
Hope you all realize that the more people get this working the less Gold Eggs will be worth in AH.
Re: Eggs
Posted: Sun Jul 04, 2010 2:53 am
by Deset
rock5 wrote:
That is because you are using an older bot. Update to the latest SVN revision. It doesn't use the mouse to harvest.
where did I get it?
downloaded the bot new did rom\update.lua but it still use the mouse..
have i to use player:harvest or player:harvestmem ?
sry for my bad englisch... im german
Re: Eggs
Posted: Sun Jul 04, 2010 4:52 am
by wizzyslo
Deset wrote:rock5 wrote:
That is because you are using an older bot. Update to the latest SVN revision. It doesn't use the mouse to harvest.
where did I get it?
downloaded the bot new did rom\update.lua but it still use the mouse..
have i to use player:harvest or player:harvestmem ?
sry for my bad englisch... im german
Administrator wrote:
SVN - Always have the newest version:
Advanced:
For those of you who already have some working knowledge of SVN, you can use this command to checkout:
svn checkout
http://rom-bot.googlecode.com/svn/trunk/ rom-bot-read-only
Simple:
First, I suggest you install Tortoise SVN. Once installed, you may need to reboot your machine. Now, locate your 'rom' folder (should be inside micromacro/scripts/) and right-click it. Select 'SVN Checkout'.
Now, a window should open. Inside "URL of repository:", enter this url:
http://rom-bot.googlecode.com/svn/trunk/rom
Everything else can be left at default. Click OK and it should begin downloading and updating all of your files. Now that you've got it all setup, you can simply right click the 'rom' folder again and select SVN update. Typically, a red icon over the folder should indicate that there are updates to download.
Problems with file conflicts?
This typically happens if you've made any modifications to the scripts. To fix it, you should delete any files that have conflicts, and try to SVN update again.
Re: Eggs
Posted: Sun Jul 04, 2010 5:39 am
by somberland
I already made a SVN-Update to 467 so that's why I'm asking because the new function won't work
Edit:// So Made a fresh SVN-Installation, now my player.lua is up2date
Re: Eggs
Posted: Sun Jul 04, 2010 5:49 am
by wizzyslo
I fix code and works better but for picking eggs I'm still useing my old script. It works much better.
Re: Eggs
Posted: Sun Jul 04, 2010 6:18 am
by rock5
somberland wrote:I already made a SVN-Update to 467 so that's why I'm asking because the new function won't work
Edit:// So Made a fresh SVN-Installation, now my player.lua is up2date
That is because everyone else here is using the modification I mentioned above to get it working. I've decided, even though I think it is only a temporary fix, to commit it to revision 468.
So update to 468. it should be a fully working for opening objects.
Re: Eggs
Posted: Sun Jul 04, 2010 6:52 am
by somberland
hmm ok looks like I killed the "eggloot"-loop
the feed and food-take function works good with the new bot-version.
Edit:// Ok same problem with the waypoints from VoidMain.
Re: Eggs
Posted: Sun Jul 04, 2010 8:57 am
by jason404
tried to make my own waypoint but still cant manage to make it work....
I've tried voidmain's example but it only manages to harvest 1 feedbag and 1 chicken while it cant find the chicken eggs.
(using the latest verison)
VoidMain wrote:Code: Select all
<?xml version="1.0" encoding="utf-8"?><waypoints type="TRAVEL">
<waypoint x="3934" z="2995">while player:harvest(112956) do yrest(2000); end;</waypoint>
<waypoint x="3935" z="3039">while player:harvest(112955) do yrest(3500);player:clearTarget(); end;</waypoint>
<waypoint x="3947" z="3107">while player:harvest(112955) do yrest(3500);player:clearTarget(); end;</waypoint>
<waypoint x="3958" z="3136">while player:harvest(112955) do yrest(5000);player:clearTarget(); end;</waypoint>
<waypoint x="3924" z="3214"> </waypoint>
<waypoint x="3914" z="3257">
while player:harvest(112955) do
yrest(8000);
end
while (player:harvest(112958)) do
yrest(1900);
sendMacro("UseSkill(1,1)");
end;
while player:harvest(114931) do
yrest(10);
end
</waypoint>
<waypoint x="3951" z="3206"> </waypoint>
<waypoint x="3938" z="3066"> </waypoint>
<waypoint x="3936" z="3035"> </waypoint>
</waypoints>
This waypoint works great with the fix sugested by rock5, never misses a chicken or an egg and also harvests 2 eggs of each one...
The check for white eggs is not on a while because it hangs the client, but this way it works great, i got 700 white eggs and 56 golden eggs this way.
Note: This is made to work with the newest version of harvesting. I still don´t get why some ppl is using an old version...