Updated database/skills.xml file

[rock5]

Why did the first 2 skills fail?

I forgot to mention, I don't have a Rogue/Mage. I do have a Champ though so what does your champ skill sequence look like?

[ZZZZZ]

Can be anything. On the r/m they failed simply because I was laging a little. But generally it bugs out when the mob dies as its being cast but before it successfully goes off. r/m has vengence sting is a retaliation hit, which can kill the mob without any imput from the bot.
And when I get the bug with Rune Pulse i am playing on ch/m. It uses High-Energy Barrier 24/7 in combat, and when the barrier breaks/runs out it does an AoE hit around your character, which can also kill off enemies without input from the bot, meaning it is still expecting Rune Pulse to finish casting even though the mob is dead.

[rock5]

As far as I know there is no loops left in the fight sequence that it can get stuck in. I had another look through it but finding a bug blindly is a monumental task with all the functions that are part of the fight sequence. Here is a list of the bigger functions involved

• player:fight
  player:checkSkills
  player:cast
  skill:use

So far my attempts at reproducing the error have failed.

Are you sure you don't have some onskillcast code that it might be getting stuck in?

[ZZZZZ]

Sorry, forgot to check this thread. I didn't have any onskill or preskill code for any character until i started making that dreamland script, and it was doing it well before then. But only with Rune pulse and Day of Rain, so no idea there.

Got this message when starting bot on champion/warlock as well:

Code: Select all

Skill Dark Energy Punishment 'uses' unknown type 1, 'usesnum' 30. Please report
to bot devs. We might be able to use it.

http://www.runesdatabase.com/skill/498655

[rock5]

I think what I might have to do is edit some files and add test prints in them for you to test. Then when it gets stuck I can tell from the printouts where it's getting stuck exactly. Replace these 2 files. When it gets stuck take a snapshot of MM and post it here. It needs to be a snapshot, not a copy&paste because I need to see the red messages.

player.lua

(129.54 KiB) Downloaded 213 times

skill.lua

(23.81 KiB) Downloaded 217 times

Skill Dark Energy Punishment 'uses' unknown type 1, 'usesnum' 30. Please report
to bot devs. We might be able to use it.

Thanks for that. Looks like it's for the HP the skill uses. We don't need to use that for the bot so I'll add an exception for it.

[ZZZZZ]

Stuck with skill: (Just standing there doing nothing, mobs beating on characters etc)

After I manually cast the skill:

[rock5]

That narrows it down. It's in player:cast (or maybe skill:use). Try these ones.

[ZZZZZ]

Same deal again: Took a fair bit longer to get the issue again this time.

After manually casting:

[rock5]

That narrows it down to a local function waitTillPriorEnds. Something it is reading from memory is not reading properly I think.

This should be the last one.

player.lua

(129.6 KiB) Downloaded 244 times

You can revert skill.lua. Just right click it and select "TortoiseSVN / Revert..."

[ZZZZZ]

ok, will try that out too. I never bother with reverting, just either delete and update, or usually keep a copy of everything. I make little changes in things, like player.lua and the target_NPC function ^.^

[ZZZZZ]

Found MM looking like this:

It was spamming the "2 prior 297 remaining -5.1 base 596143104 offset 37" until I manually cast Day of Rain, at which point it continued.

[rock5]

Hm... skill:getRemainingCooldown() is returning -5.1. I have no idea why that happens for that skill but lets see if just checking for negative numbers and returning 0 fixes it.

The file with the fix is skill.lua. You can restore player.lua.

skill.lua

(23.67 KiB) Downloaded 240 times

Make sure you let me know if it fixes it or causes other problems.

[lisa]

hmmm lvl 50 elite, if I find the time I might lvl up a char on private server to check it out, may not be any time soon though.

The description is interesting though

Consumes 3.0% HP every second and increases Physical Attack Power by 5.0% and Magical Attack Power by 5.0%. (This state ends when HP has been exhausted.)

Maybe it is counting how long til you run out of HP ?

[rock5]

I had to look it up to know what you were talking about. The description says "Consumes 3.0% HP every second" but just under the name (using ItemPreview) it says "Uses 30 HP". So I suspect it uses an initial 30 HP plus 3.0% every second. The "30" corresponds with the usesnum value so I assume that's what it is.

[ZZZZZ]

Ran Dreamland for about 5 hours today while I was out, it farmed 2000 badges. So that change must have fixed it Rock

[rock5]

Ran Dreamland for about 5 hours today while I was out, it farmed 2000 badges. So that change must have fixed it Rock

Excellent!

excellent.jpg (4.51 KiB) Viewed 5947 times

[ZZZZZ]

A few more skill errors. There are all to do with warrior/champion. They all have HP and HP% requirements.

Code: Select all

Skill Slash 'uses' unknown type 1, 'usesnum' 25. Please report to bot devs. We m
ight be able to use it.
Skill Blood Rune Weapon 'uses' unknown type 1, 'usesnum' 27. Please report to bo
t devs. We might be able to use it.
Skill Bloody Slash 'uses' unknown type 1, 'usesnum' 30. Please report to bot dev
s. We might be able to use it.
Skill Unbridled Rage 'uses' unknown type 1, 'usesnum' 27. Please report to bot d
evs. We might be able to use it.
Skill Stifling Attack 'uses' unknown type 1, 'usesnum' 31. Please report to bot
devs. We might be able to use it.
Skill Vendetta Blow 'uses' unknown type 1, 'usesnum' 27. Please report to bot de
vs. We might be able to use it.

Blood Rune Weapon: http://www.runesdatabase.com/skill/4987 ... une-weapon
Bloody Slash: http://www.runesdatabase.com/skill/498763/bloody-slash
Unbridled Rage: http://www.runesdatabase.com/skill/4987 ... idled-rage
Stifling Attack: http://www.runesdatabase.com/skill/4988 ... ing-attack
Vendetta Blow: http://www.runesdatabase.com/skill/498822/vendetta-blow

[rock5]

Yeah, I've already added 'type 1' to the bot so you wont get those messages anymore. I just haven't committed it yet. So the next time I commit, they'll be gone.

[ZZZZZ]

ahh kk

[cibervagos]

Hi all. Im not a english speaker, so my english is pretty bad. I have some problem with my druid/warrior. My healing wind dosnt work. I solved cross of thorns attack issues changing id to 499956 in skill.xml. But I cant make my Healing Wind work