[solved] bug accepting daily AND public quests together

[Celesteria]

hello there,

in the new map is a daily quest calles "Adlerjagd" in german. I dont know the name of the quest for english clients, maybe "Eagle hunt" or something like this. The quest is to kill an eagle witch drops a feather. If you accept daily and public quests it drops two feathers, so you can do the dailies in half the time. But the bot is not able to accept both quests. I used the following test:

Code: Select all

<!-- #  1 --><waypoint x="21154" z="38279"><![CDATA[
print ('0: public: '..getQuestStatus (427029)..' - daily: '..getQuestStatus (427019))

if getQuestStatus (427019)=='not accepted' then
  player:target_NPC (123313)
  AcceptQuestByName (427019)
end

print ('1: public: '..getQuestStatus (427029)..' - daily: '..getQuestStatus (427019))

if getQuestStatus (427029)=='not accepted' then
  player:target_NPC (123313)
  AcceptQuestByName (427029)
end

print ('2: public: '..getQuestStatus (427029)..' - daily: '..getQuestStatus (427019))
]]></waypoint>

result:
------
0: public: not accepted - daily: not accepted
Wir versuchen den NPC 123313 zu finden:
Der NPC 'Kaimo Bleigh' wurde erfolgreich ausgewählt. Wir öffnen das Dialogfenster.
Quest accepted: Adlerjagd
1: public: not accepted - daily: incomplete
Wir versuchen den NPC 123313 zu finden:
Der NPC 'Kaimo Bleigh' wurde erfolgreich ausgewählt. Wir öffnen das Dialogfenster.
Quest already accepted: Adlerjagd
2: public: not accepted - daily: incomplete


using another way it gives another wrong result:

Code: Select all

<!-- #  1 --><waypoint x="21154" z="38279"><![CDATA[
local questName = GetIdName (427029)

print ('0: public: '..getQuestStatus (questName,'public')..' - daily: '..getQuestStatus (questName,'daily'))

if getQuestStatus (questName,'public')=='not accepted' then
  player:target_NPC (123313)
  AcceptQuestByName (questName,'public')
end

print ('1: public: '..getQuestStatus (questName,'public')..' daily: '..getQuestStatus (questName,'daily'))

if getQuestStatus (questName,'daily')=='not accepted' then
  player:target_NPC (123313)
  AcceptQuestByName (questName,'daily')
end

print ('2: public: '..getQuestStatus (questName,'public')..' daily: '..getQuestStatus (questName,'daily'))

result:
------
0: public: not accepted - daily: not accepted
Wir versuchen den NPC 123313 zu finden:
Der NPC 'Kaimo Bleigh' wurde erfolgreich ausgewählt. Wir öffnen das Dialogfenster.
Quest accepted: Adlerjagd
1: public: incomplete - daily: incomplete
2: public: incomplete - daily: incomplete

--> both quests show "incomplete", but only the public quest is accepted


The only workaround at this time is to use AcceptAllQuests (). This is ok at the moment, because the npc only has this two quests. But with other npcs with more quests this is not really a good solution. I didnt find the point where to search for the bug. If I understand it right its seems to be a problem directly in the igf-scripts. Any ideas?


greetings
Celesteria

[rock5]

Do you have the QuestLogClass userfunction installed? Is it the latest version? Try updating it or removing it altogether.

[Celesteria]

Do you have the QuestLogClass userfunction installed? Is it the latest version? Try updating it or removing it altogether.

I never realized there is such a userfunction
I updated it to version 0.06 - the last version I found in this forum. But the results are the same. I also removed it completely and it doesnt change anything.

Code: Select all

table.print (getQuestBaseData(427029))
table.print (getQuestBaseData(427019))

results are correct as long as I can see:

Code: Select all

table: 099AA8D8
QuestTaker:     table: 099AB1E8
Name:   Adlerjagd
AcceptLevel:    89
KillGoals:      table: 099AB418
QuestGroup:     3 <------------------------------ correct group
BaseItemAddress:        416312432
ItemGoals:      table: 099AB238
        1:      table: 099AB260
                NumReq: 1
                Id:     243109
                IdType: 2
                BaseItemAddress:        867057408
                Name:   Schwanzfeder des Adlerk├Ânigs
Id:     427029
QuestGiver:     table: 099AAE50
        1:      table: 099AAEA0
                Name:   Kaimo Bleigh
                Id:     123313
Level:  91



table: 099AB7D8
QuestTaker:     table: 099AB990
Name:   Adlerjagd
AcceptLevel:    89
KillGoals:      table: 099ABA08
QuestGroup:     2 <------------------------------ correct group
BaseItemAddress:        416296392
ItemGoals:      table: 099AB9B8
        1:      table: 099AB9E0
                NumReq: 1
                Id:     243109
                IdType: 2
                BaseItemAddress:        867057408
                Name:   Schwanzfeder des Adlerk├Ânigs
Id:     427019
QuestGiver:     table: 099AB940
        1:      table: 099AB968
                Name:   Kaimo Bleigh
                Id:     123313
Level:  91

[EDIT]
oh my mistake ... I tested it again and now it works if I use the second example I postet before. So it can accept the quest by name and 'public' or 'daily'. But using the quest-id its still not working. wired thing
[/EDIT]

[rock5]

I'm glad you got it working. I thought we fixed these sort of issues, especially when using ids.

I had a bit of a look and I think I see what will fix it. Open functions.lua and around line 1838 you will see this line

Code: Select all

	if questToAccept ~= "all" and getQuestStatus(questToAccept, _questgroup) ~= "not accepted" then

Change it to

Code: Select all

	if questToAccept ~= "all" and getQuestStatus(_nameorid, _questgroup) ~= "not accepted" then

See if that works.

[Celesteria]

yessss, this works.

0: public: not accepted - daily: not accepted
Wir versuchen den NPC 123313 zu finden:
Der NPC 'Kaimo Bleigh' wurde erfolgreich ausgewählt. Wir öffnen das Dialogfenster.
Quest accepted: Adlerjagd
1: public: not accepted - daily: incomplete
Wir versuchen den NPC 123313 zu finden:
Der NPC 'Kaimo Bleigh' wurde erfolgreich ausgewählt. Wir öffnen das Dialogfenster.
Quest accepted: Adlerjagd
2: public: incomplete - daily: incomplete


many thanks
Celesteria

[rock5]

Hopefully that doesn't introduce any other problems. I'll include it in the next commit.