Code: Select all
Fixed: Lots of buffer overflow protection changes (no more strcpy, strncpy, strcat, strncat)
Fixed: A few minor memory leaks (Thanks, CppCheck!)
Changed: Use strftime() instead of asctime()
Fixed: Redundant memset() in luaengine.cpp:645. Whoops!
Fixed: check if readBuffer is valid *before* memsetting it in memorydevice.cpp:35
So, mostly boring stuff, right? So why do I bother mentioning this? Because it is difficult to test the new buffer enforcement code in every circumstance. While it *shouldn't* cause any issues from my initial testing, it is possible that strings copied into buffers might behave strangely (get unexpectedly truncated, for example), while not causing an error.
For example, while I was working on the changes, I noticed that the URL that is displayed on start (solarstrike.net in green) was, instead, showing:
Code: Select all
SolarStrike Software
http://www.solarstrike.n
In addition, I'd like to move towards marking 1.04 as done, so any last-minute changes should be proposed now.