Rock5's ToDo list

[rock5]

This has been suggested before as onWaypoint. I believe Administrator never liked the idea or didn't see the need. A solution was proposed to create a timed event. Escentially you would create and start the timed event in the onload section on the waypoint and it would fire after every x number of seconds.

Check out the wiki
http://www.solarstrike.net/wiki/index.p ... isterTimer

[Tsutomu]

Yes, that's an idea, but isn't nowhere near quality of implementation of OnWaypoint-OnArrive whatever, as it fires up somewhere we don't know where, it is different every time it's used, what we need is an Event based on position not time.
We can fire that time based event every 0.5 seconds and it'd be good enough but there's a chance it'll be too cpu consuming, and ending up bringing us stuck if launched at wrong places.
But never mind, really just thought of it as a good option if it was implementable quickly, skip looting few mobs isn't that much of a waste is it.
Thanks.

[Tsutomu]

-------
I would like to sugges few ideas.
(not concerning hacks something else)

I think that a screenshot on death is good option, but also, screnshot on stuck, or stuck+10failed attempts unstucking would be very usefull in finding out what went wrong with waypoint file.

Also i think it might be good to implement a function to load a script if bot is stuck
That way we could for ex. Leave party, then load up a waypoint that starts from ressurection point.

Just making it more stuck-proof and troubleshooting waypoint files (screenshot on stuck option).

If those are time-consuming to implement i offer to try it myself, just would need an instruction which files should i look in. I think that if we manage to get this working it would be a nice addition to it's functions, i think it would be very usefull to all of us.

I had one more thing in mind but forgot, too late for deep thoughts i guess.

[lisa]

-------
I would like to sugges few ideas.
(not concerning hacks something else)

I think that a screenshot on death is good option, but also, screnshot on stuck, or stuck+10failed attempts unstucking would be very usefull in finding out what went wrong with waypoint file.

Also i think it might be good to implement a function to load a script if bot is stuck
That way we could for ex. Leave party, then load up a waypoint that starts from ressurection point.

Just making it more stuck-proof and troubleshooting waypoint files (screenshot on stuck option).

If those are time-consuming to implement i offer to try it myself, just would need an instruction which files should i look in. I think that if we manage to get this working it would be a nice addition to it's functions, i think it would be very usefull to all of us.

I had one more thing in mind but forgot, too late for deep thoughts i guess.

There is a profile section for stuck code

Code: Select all

	<onUnstickFailure><![CDATA[
		-- Lua code to execute when MAX_UNSTICK_TRIALS is reached.
	]]></onUnstickFailure>

When the bot reaches max number of unstuck tries, 10 by default, it will then load what ever code you put in this section.

[rock5]

Buy the way, this thread is not for making feature requests. It's only to discuss my current list and the items already on it.

Please create your own thread for feature requests.

[Tsutomu]

ok sorry

thx

[vietales]

Increase range of inventory to include transmutor and item shop. Progress Complete

Have u published it?

[rock5]

Increase range of inventory to include transmutor and item shop. Progress Complete

Have u published it?

Yeh, long time ago, in December I think. If my list say 'Progress Complete' then it means it was committed. Check out the wiki for how to use the updated inventory functions.
http://www.solarstrike.net/wiki/index.p ... _Functions

[Alkaiser]

A suggestion for lootAll() function.

It seems that there are times the mob won't get looted properly... the player will start to move toward the lootable target, then stop short for no apparent reason. The target gets added to the do-not-loot list and never gets looted.

I have made the following change that will force the bot to try up to 3 times before giving up. It's working great for me so far... been using it work weeks (I made the same change to lootBodies() before lootAll() was integrated)

Code: Select all

	local retry = 3
	while true do
		self:update()
		if( self.Battling  and
			self:findEnemy(true,nil,evalTargetDefault)) then
			break
		end

		local Lootable = self:findEnemy(false, nil, evalTargetLootable)

		if Lootable == nil then
			break
		end

		self:target(Lootable)
		self:update()
		if self.TargetPtr ~= 0 then -- Target's still there.
			self:loot()
			yrest(50)
			Lootable:update();
			if Lootable.Lootable == true then
				if retry == 0 then
					-- Failed to loot. Add to ignore list
					lootIgnoreListPos = lootIgnoreListPos + 1
					if lootIgnoreListPos > settings.profile.options.LOOT_IGNORE_LIST_SIZE then lootIgnoreListPos = 1 end
					lootIgnoreList[lootIgnoreListPos] = Lootable.Address
				else
					retry = retry - 1
				end
			end
		end
	end

[rock5]

How long does it take to try 3 times if a body isn't lootable? I'm thinking there might be places where you encounter a lot of bodies that you can't loot so always trying 3 times might slow it down eg. an area where mobs are dropping daily items that you already have the maximum you can carry in your inventory.

[Alkaiser]

How long does it take to try 3 times if a body isn't lootable? I'm thinking there might be places where you encounter a lot of bodies that you can't loot so always trying 3 times might slow it down eg. an area where mobs are dropping daily items that you already have the maximum you can carry in your inventory.

Not sure I understand. Do you mean if there is an obstacle between the loot and player? It doesn't loot at all if the mob isn't lootable. If there is a need for a loot retry there is a few second delay between each attempt though I don't know where they delay comes from. If inventory is full the loop breaks just as you designed it so it won't try to loot again and again if there is no space available. If loot is successful it won't try to loot again since Lootable.Lootable should be false.

[rock5]

What I meant is, in some zones you can only hold enough items for the daily and no more. For example in the Northern Janost Forest many of the dailies need 5 items and when collectiong them you can't pick up anymore once you have 5, although the monsters still drop them. That means if you are in such a zone and area where daily items are dropped, if you already have the maximum amount of that item, you would continuously be trying 3 times to loot those daily items.

I think I know what your initial problem was. It's when the character slightly bumps into something then stops moving forward. So the problem is not so much the looting but the movement. The player:moveTo function doesn't suffer from this problem because it keeps moving forward until it reaches its desination. But player:loot() effectively just clicks the body and allows the character to move there on it's own. Maybe what we need is a distance check in loot() so it can try again only if it's still out of range to loot? If it's in range it only tries once?

[rock5]

I've had a look at the loot function and there is already a 'try again' feature in it. You set LOOT_AGAIN, in your profile options, to a number and it will try again after waiting LOOT_AGAIN ms. Except it only tries again if the character didn't move. If the character stops part way, it won't loot again. But this could be adjusted to loot again when out of range, regardless of whether it moved or not.

Would you like to test a fix for me?

[Alkaiser]

I've had a look at the loot function and there is already a 'try again' feature in it. You set LOOT_AGAIN, in your profile options, to a number and it will try again after waiting LOOT_AGAIN ms. Except it only tries again if the character didn't move. If the character stops part way, it won't loot again. But this could be adjusted to loot again when out of range, regardless of whether it moved or not.

Would you like to test a fix for me?

Certainly!

[rock5]

Around line 1381 of player.lua you will see these lines

Code: Select all

		self.X == hf_x  and	-- we didn't move, seems attack key is not defined
	    self.Z == hf_z  and

Comment them out or delete them all together

Code: Select all

		--self.X == hf_x  and	-- we didn't move, seems attack key is not defined
	    --self.Z == hf_z  and

And don't forget to set LOOT_AGAIN in the profile.

[Alkaiser]

I added

Code: Select all

<option name="LOOT_AGAIN" value="3" />

and commented the lines you suggested. It works more often now, but still occasionally gives up right away after moving two steps then stopping.

UPDATE:
I also added this to my profile:

Code: Select all

<option name="LOOT_TIME"			value="10" />

It seems to be working 100% now.

[rock5]

With these changes it tries 2 times. I suspect, those times where it still stops, it would stop even if it tried 3 times.

I'll think about it and see if I can come up with a reliable solution.

[Alkaiser]

I also added this to my profile:

Code: Select all

<option name="LOOT_TIME"			value="10" />

It seems to be working 100% now.

[rock5]

I also added this to my profile:

Code: Select all

<option name="LOOT_TIME"			value="10" />

It seems to be working 100% now.

I'm not sure I understand how that could help but do some more testing and let me know how it goes. I'll try to figure out how it helps.

[Alkaiser]

The only thing I could think of is the distance calculation used to determine how much time to allow for looting isn't quite right. I'll remove the LOOT_TIME and see what happens.

UPDATE: I removed it and it still seems to be working. Not sure why it wasn't working right before.