Improve code for the elfs daily quest

Runes of Magic/Radiant Arcana (http://www.runesofmagic.com)
Message
Author
User avatar
rock5
Posts: 12173
Joined: Tue Jan 05, 2010 3:30 am
Location: Australia

Re: Improve code for the elfs daily quest

#61 Post by rock5 » Fri Mar 04, 2011 9:53 am

Tamyra wrote:Is there a better coding distance that should help avoid the speed of the gather being too fast?
By going too fast, I mean it tries again before it has registered that it already has the item. By adding a pause, it has time to register that it has the item so it only harvests once. Harvest distance is used to only harvest items within a certain distance. There is only 1 harvestable and only 1 Blinsik so in this situation, it has no use.

The same is true with the npc. If you don't give the dialog time to open, then you'll be trying to accept the quest before it's ready.
  • Please consider making a small donation to me to support my continued contributions to the bot and this forum. Thank you. Donate
  • I check all posts before reading PMs. So if you want a fast reply, don't PM me but post a topic instead. PM me for private or personal topics only.
  • How to: copy and paste in micromacro
    ________________________
    Quote:
    • “They say hard work never hurt anybody, but I figure, why take the chance.”
          • Ronald Reagan

Tamyra
Posts: 133
Joined: Tue Feb 01, 2011 6:09 pm

Re: Improve code for the elfs daily quest

#62 Post by Tamyra » Sat Mar 05, 2011 9:23 am

OMG, it works SO much better!! But, as one problem resolves itself another one comes back, and it seems the water portion of the return path has the bot "dolphin jumping" out of the water every other second. So I was wondering if the create waypoint part of the bot with the third axis is what effects height of the bot, so I can be sure to keep it under water?

User avatar
lisa
Posts: 8332
Joined: Tue Nov 09, 2010 11:46 pm
Location: Australia

Re: Improve code for the elfs daily quest

#63 Post by lisa » Sun Mar 06, 2011 5:01 am

Pretty sure the bot doesn't know how to move up or down, with the low amount of actual going through water required in RoM I doubt it would be worthwhile to write the coding to actually make it move up and down.

I'd need to test but I'm pretty sure jump or sit doesn't move your character up and down in water so you would need to change the direction the character is looking in order to make it do this.
Remember no matter you do in life to always have a little fun while you are at it ;)

wiki here http://www.solarstrike.net/wiki/index.php?title=Manual

Tamyra
Posts: 133
Joined: Tue Feb 01, 2011 6:09 pm

Re: Improve code for the elfs daily quest

#64 Post by Tamyra » Sat Apr 02, 2011 2:32 pm

Okay, I'm not sure what's going on, but for some reason my bot now does not work for this daily, and continually pauses and/or gets stuck on the grass it is running across. I didn't change anything with the waypoint either. Any suggestions?
Attachments
Stuck.jpg

User avatar
lisa
Posts: 8332
Joined: Tue Nov 09, 2010 11:46 pm
Location: Australia

Re: Improve code for the elfs daily quest

#65 Post by lisa » Sat Apr 02, 2011 8:59 pm

Could it be the usage of Y axis now causing the issue?
Remember no matter you do in life to always have a little fun while you are at it ;)

wiki here http://www.solarstrike.net/wiki/index.php?title=Manual

User avatar
rock5
Posts: 12173
Joined: Tue Jan 05, 2010 3:30 am
Location: Australia

Re: Improve code for the elfs daily quest

#66 Post by rock5 » Sat Apr 02, 2011 9:16 pm

As far as I know, when calculating distance, if there is no 'y' value it just uses the 'x' and 'z' values and should still work. And if that was the problem, wouldn't he be having problems at every waypoint instead of just a few?
  • Please consider making a small donation to me to support my continued contributions to the bot and this forum. Thank you. Donate
  • I check all posts before reading PMs. So if you want a fast reply, don't PM me but post a topic instead. PM me for private or personal topics only.
  • How to: copy and paste in micromacro
    ________________________
    Quote:
    • “They say hard work never hurt anybody, but I figure, why take the chance.”
          • Ronald Reagan

Tamyra
Posts: 133
Joined: Tue Feb 01, 2011 6:09 pm

Re: Improve code for the elfs daily quest

#67 Post by Tamyra » Mon Apr 04, 2011 4:39 pm

It actually only got as far as it did because I interceded on the bot's behalf and pointed it in the right direction. It WAS stopping and getting stuck at every waypoint.....on the grass. In the water it did not seem to be having any issues.

User avatar
rock5
Posts: 12173
Joined: Tue Jan 05, 2010 3:30 am
Location: Australia

Re: Improve code for the elfs daily quest

#68 Post by rock5 » Mon Apr 04, 2011 8:23 pm

So do all your other waypoint files still work? If you change character and/or profile does it still do it? If you create a new waypointfile does it work better?

By the way, I still have a copy of yout waypoint file and it still works perfectly for me.
  • Please consider making a small donation to me to support my continued contributions to the bot and this forum. Thank you. Donate
  • I check all posts before reading PMs. So if you want a fast reply, don't PM me but post a topic instead. PM me for private or personal topics only.
  • How to: copy and paste in micromacro
    ________________________
    Quote:
    • “They say hard work never hurt anybody, but I figure, why take the chance.”
          • Ronald Reagan

Tamyra
Posts: 133
Joined: Tue Feb 01, 2011 6:09 pm

Re: Improve code for the elfs daily quest

#69 Post by Tamyra » Wed Apr 06, 2011 9:48 am

Yeah I went back a few posts to my original waypoint where the wait time was a little fast, and it is checking twice for the item. It worked with the exception of that, plus the section in the water is a bit iffy with the dolphin swimming, but at least it does the job. I'll stick with that for now.

Tamyra
Posts: 133
Joined: Tue Feb 01, 2011 6:09 pm

Re: Improve code for the elfs daily quest

#70 Post by Tamyra » Mon Apr 11, 2011 9:44 am

And it worked for all of 2 days, now it is right back where I started but worse, now both water and grass are sticking at every waypoint. I even tried recording a new path, in case frogster got wise and modified the terrain with a few bumps in the grass and got ... nothing. Still gets stuck, so I am convinced it is something else. And this is the ONLY bot that's doing this. Any suggestions on how to fix this would be great. Or if anyone else has a working waypoint that I can test (in english preferably)? Thanks in advance.

Edit: Should I try to delete the associated macro in game that's created when a new bot is loaded? Then restart it fresh? Will that do anything?

User avatar
lisa
Posts: 8332
Joined: Tue Nov 09, 2010 11:46 pm
Location: Australia

Re: Improve code for the elfs daily quest

#71 Post by lisa » Mon Apr 11, 2011 9:53 am

I am starting to think it might be a machine resource issue. Do you have lots of programs running at the same time? If not then maybe look into your ram to see if it isn't working properly, check out some performance software.
Remember no matter you do in life to always have a little fun while you are at it ;)

wiki here http://www.solarstrike.net/wiki/index.php?title=Manual

Tamyra
Posts: 133
Joined: Tue Feb 01, 2011 6:09 pm

Re: Improve code for the elfs daily quest

#72 Post by Tamyra » Mon Apr 11, 2011 10:01 am

Only have the game and micromacro running, everything else is off. And like I said, this is the only bot that it does this to. I collect eggs at millers ranch just fine. And I only run one instance of the game at a time on this computer. I've even tried putting it on low resolution with the distance view the same as normal resolution so that it uses less resources.

User avatar
rock5
Posts: 12173
Joined: Tue Jan 05, 2010 3:30 am
Location: Australia

Re: Improve code for the elfs daily quest

#73 Post by rock5 » Mon Apr 11, 2011 7:59 pm

I'd say the problem is with your profile or character because I have a copy of the waypoint file you are using and it works fine for me.

So if you have been using the same profile try to use the default profile.

If you have been using the same character try it with a different character.
  • Please consider making a small donation to me to support my continued contributions to the bot and this forum. Thank you. Donate
  • I check all posts before reading PMs. So if you want a fast reply, don't PM me but post a topic instead. PM me for private or personal topics only.
  • How to: copy and paste in micromacro
    ________________________
    Quote:
    • “They say hard work never hurt anybody, but I figure, why take the chance.”
          • Ronald Reagan

Tamyra
Posts: 133
Joined: Tue Feb 01, 2011 6:09 pm

Re: Improve code for the elfs daily quest

#74 Post by Tamyra » Thu Apr 14, 2011 9:47 am

I named the waypoint elfdaily.xml, and the profile tiering.xml, so the profile itself is being used on all characters as they cycle through on auto log in. I have 4 different accounts with 8 characters each, and it does not work on any of them. The only thing I can think of is that sometimes it messes up and gets stuck when trying to do a skill that the character does not yet have the level to do. Or a skill like flame, on a rogue, so mismatched skill for wrong class. So my next question would be, how do I turn off all the skills?

User avatar
rock5
Posts: 12173
Joined: Tue Jan 05, 2010 3:30 am
Location: Australia

Re: Improve code for the elfs daily quest

#75 Post by rock5 » Thu Apr 14, 2011 10:04 am

Ok so the problem is not a character related problem because it happens with all your characters so it's most likely your profile. What happened when you tried the default.xml profile like I suggested?
  • Please consider making a small donation to me to support my continued contributions to the bot and this forum. Thank you. Donate
  • I check all posts before reading PMs. So if you want a fast reply, don't PM me but post a topic instead. PM me for private or personal topics only.
  • How to: copy and paste in micromacro
    ________________________
    Quote:
    • “They say hard work never hurt anybody, but I figure, why take the chance.”
          • Ronald Reagan

Tamyra
Posts: 133
Joined: Tue Feb 01, 2011 6:09 pm

Re: Improve code for the elfs daily quest

#76 Post by Tamyra » Thu Apr 14, 2011 10:10 am

lol Well seeing as I have just now read this when at work, I have not yet tried to implement it, but I can tell you that my "tiering.xml" profile is an exact copy of the default profile with 2 exceptions. The name of the waypoint elfdaily.xml has been added, and that I have set the "quickturn" setting to true.

User avatar
rock5
Posts: 12173
Joined: Tue Jan 05, 2010 3:30 am
Location: Australia

Re: Improve code for the elfs daily quest

#77 Post by rock5 » Thu Apr 14, 2011 11:37 am

Skills shouldn't be a problem because it should only load the correct skills for the class but I just tested this

Code: Select all

                  -- Re-initialize player
              player = CPlayer.new();
              settings.load();
              settings.loadProfile("tiering"); -- Profile name
and found it didn't work properly when loading a new character. The skills loaded included the skills from the previous character. I don't understand how that's happening. settings.loadProfile probably needs to be fixed.

But in your case, becasue you use the same profile with all characters and now that I've added auto skill set changing, you could try leaving out the "settings.loadProfile("tiering")" line.
  • Please consider making a small donation to me to support my continued contributions to the bot and this forum. Thank you. Donate
  • I check all posts before reading PMs. So if you want a fast reply, don't PM me but post a topic instead. PM me for private or personal topics only.
  • How to: copy and paste in micromacro
    ________________________
    Quote:
    • “They say hard work never hurt anybody, but I figure, why take the chance.”
          • Ronald Reagan

Tamyra
Posts: 133
Joined: Tue Feb 01, 2011 6:09 pm

Re: Improve code for the elfs daily quest

#78 Post by Tamyra » Thu Apr 14, 2011 1:04 pm

Where does that go? I have not seen that code before. Duh, never mind, I found it, so just delete the whole line?

User avatar
rock5
Posts: 12173
Joined: Tue Jan 05, 2010 3:30 am
Location: Australia

Re: Improve code for the elfs daily quest

#79 Post by rock5 » Thu Apr 14, 2011 7:26 pm

Just try deleting the whole settings.loadProfile line.

I still don't understand what's happening with the skills. There's something happening that I don't understand with the variables. Maybe Administrator knows?

If I load a rogue and start the bot commandline, that loads the rogues skills.

If I then switch to my priest and execute these 2 commands

Code: Select all

              player = CPlayer.new();
              settings.load();
and check the loaded skills, I find that any general skills and priest skills from the rogue profile are already loaded.

If I then execute

Code: Select all

settings.loadProfile("priest_profile");
I end up with a mixture of my priest skills from the priest profile and rogue skills from my rogue profile that seem to have appeared from nowhere.

If I run my
settings.loadSkillSet(class) command. The skills are all correct.

I think I might know what the problem is. I just checked settings_default.profile.skills and instead if being empty, it has skills in it. I don't know how that happened as the only time settings_default is used is through the table.copy command.

I must be missing something. :?: Maybe table.copy doesn't copy subtables properly?
  • Please consider making a small donation to me to support my continued contributions to the bot and this forum. Thank you. Donate
  • I check all posts before reading PMs. So if you want a fast reply, don't PM me but post a topic instead. PM me for private or personal topics only.
  • How to: copy and paste in micromacro
    ________________________
    Quote:
    • “They say hard work never hurt anybody, but I figure, why take the chance.”
          • Ronald Reagan

User avatar
rock5
Posts: 12173
Joined: Tue Jan 05, 2010 3:30 am
Location: Australia

Re: Improve code for the elfs daily quest

#80 Post by rock5 » Thu Apr 14, 2011 10:42 pm

Yes, Ive confirmed that the problem is table.copy. I've tested a fix and it works. When loading new profiles it properly clears the old. I've PMed Administrator to add the fix to micromacro as I'm not sure if I have authority to update it.

Please note, Tamyra, I'm not 100% sure if this will fix your original problem.
  • Please consider making a small donation to me to support my continued contributions to the bot and this forum. Thank you. Donate
  • I check all posts before reading PMs. So if you want a fast reply, don't PM me but post a topic instead. PM me for private or personal topics only.
  • How to: copy and paste in micromacro
    ________________________
    Quote:
    • “They say hard work never hurt anybody, but I figure, why take the chance.”
          • Ronald Reagan

Post Reply

Who is online

Users browsing this forum: Ahrefs [Bot], Google [Bot] and 3 guests