RoM server Patch 4.0.3. - The Mighty Shield.

[brujilla]

yes, the bot starts up and select the waipoint starts fine when the script is in 1 and does not move if you find a hen does not feed her or do anything it is fixed there doing nothing

[lisa]

start it with debug so like

Code: Select all

rom/bot path:millers debug

change millers to the WP name of course.
Then copy what it has on MM window to here.

[sdude13]

latest revision works, but i get "GetNumPartymembers()" Macro spamed all the time..

[lisa]

latest revision works, but i get "GetNumPartymembers()" Macro spamed all the time..

All the time? or every 60 seconds?

[brujilla]

This happens and so I have the action bar to see if macros and failure of the update

[sdude13]

latest revision works, but i get "GetNumPartymembers()" Macro spamed all the time..

All the time? or every 60 seconds?

every time (like every 0.2 second)

fighting bot, soloplay.

[nerdyone255]

latest revision works, but i get "GetNumPartymembers()" Macro spamed all the time..

All the time? or every 60 seconds?

partyhealer seems to work in 651 for me, errored out in 652.

in 651 partydps doesnt find my party members though. messing around with it now.

attached is a screen from partydps. once every 60s its cast, but never really finds my party leader

[SpiralV]

urgs some bugfixing here Lisa

Code: Select all

function GetPartyMemberName(_number)

	if type(_number) ~= "number" or _number < 1 then
		print("GetPartyMemberName(number): incorrect value for 'number'.")
		return
	end

	if partymembers == nil or _lastupdated == nil or (os.time() - _lastupdated) >= 60 then
		partymembers={}
		-- 0 = no party 2 = 1 partymember ...
		local nummembers = sendMacro("GetNumPartyMembers()")
		-- exclude player with -1
		for i = 1, nummembers - 1 do
			local _name = sendMacro("GetPartyMember("..i..")")
			table.insert(partymembers,i, _name)
		end
		_lastupdated = os.time()
	end

	return partymembers[_number]
end

I think it's ok if the table is empty then there is no party?

[lisa]

urgs some bugfixing here Lisa

Agreed, was looking at the code I did, I must have been half asleep when i did it lol

yeah the 0 for solo and 2 for 1 party member took me by surprise. Trouble was I haven't been able to test most of the code I've done last 2 days, so I am not surprised there were problems.

Testing the code you posted now though.
Solo is working fine

need to see if I can test with partydps, partyhealer aswell.

[nerdyone255]

urgs some bugfixing here Lisa

Testing the code you posted now though.
Solo is working fine

need to see if I can test with partydps, partyhealer aswell.

where is that getpartymembername function? i have my dps/healers all logged and ready to test

[lisa]

Tested solo and worked with no sendMacro spamm

Tested partyhealer and partydps with 2 chars in party worked fine.

Something to keep in mind is that we arn't using memory for the information at this stage, still need to find the new address. So it is using an ingame function to get the name and then using findnearestnameorid to get the pawn information. The names only update every 60 seconds and isn't affected by joining or leaving party. So if you disban party and then it does the name update while you are disbanded it will return no information for party member names for the next 60 seconds.

This is not ideal of course, ideal is to find the new address which is why this code is still very crude. Once we get new address it will become obsolete.

Anyway update to latest revision and party bot should be fine again, including solo botting.

Thanks SpiralV for the code.

[SpiralV]

where is that getpartymembername function? i have my dps/healers all logged and ready to test

.functions.lua 1268

[rock5]

Well egg bot is running with out crashes as of rev 560. The optimized script however isn't counting golden eggs correctly. It says I have collected 14 in two hours..but I really collected 17.

I fear my question was overlooked as did the one in the main eggbot thread.

Frankly, at this stage, with all I have on my plate, I couldn't care less if the numbers are wrong.

But a quick answer is it doesn't start counting until you start on a fresh stack of "Fresh Eggs". So if you have it turning in the quests after collecting 100 eggs and you started with 50, then it wont start counting until you reach 100 and turned in the first batch. So if you found a few Golden Eggs in that time they wont be counted. I know thats stupid. I always intended to fix that up but it was never a priority.

An easy way to have it count all eggs is to complete the quest until your fresh eggs fall below 10 then start the bot and it will start counting right away.

[Balofar]

I get the crash only by one character, all other works fine. What can this means?

[nerdyone255]

Anyway update to latest revision and party bot should be fine again, including solo botting.

Thanks SpiralV for the code.

hm partydps.xml still isnt picking up my main char and following it. partyhealer is fine though.

going to go a clean install of the entire directory and see if that fixes it.

[lisa]

Anyway update to latest revision and party bot should be fine again, including solo botting.

Thanks SpiralV for the code.

hm party dps still isnt picking up my main char and following it. partyhealer is fine though.

going to go a clean install of the entire directory and see if that fixes it.

Sorry my bad, in all the updates and with so much going on forgot to update people on changes I did to party bot.

I'll start a new topic for it and explain there, I'll add link here once I make the topic.
here

[Nevex]

Well egg bot is running with out crashes as of rev 560. The optimized script however isn't counting golden eggs correctly. It says I have collected 14 in two hours..but I really collected 17.

I fear my question was overlooked as did the one in the main eggbot thread.

Frankly, at this stage, with all I have on my plate, I couldn't care less if the numbers are wrong.

But a quick answer is it doesn't start counting until you start on a fresh stack of "Fresh Eggs". So if you have it turning in the quests after collecting 100 eggs and you started with 50, then it wont start counting until you reach 100 and turned in the first batch. So if you found a few Golden Eggs in that time they wont be counted. I know thats stupid. I always intended to fix that up but it was never a priority.

An easy way to have it count all eggs is to complete the quest until your fresh eggs fall below 10 then start the bot and it will start counting right away.

No problem Rock. You gave me insight into how it works and now I understand completely how it counts. Fixing it is no longer a concern. Thanks for your hard work.

[Dsanchez]

Tested solo and worked with no sendMacro spamm

Code: Select all

Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Stopping waypoint: Target acquired before moving.
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "SetRaidTarget("target", 1);".
Engaging enemy [Screaming Gargoyle] in combat.
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use 1: SCOUT_VAMPIRE_ARROWS=>   Screaming Gargoyle (3422/3621)
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
MACRO: Using HP potion 2173/2415 (89%): Military Regeneration Formula (qty 57)
Use 1: SCOUT_SHOT          =>   Screaming Gargoyle (1901/3621)
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use H: ROGUE_SHADOW_STEP   =>   Screaming Gargoyle (1358/3621)
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use 2: ROGUE_SHADOWSTAB    =>   Screaming Gargoyle (725/3621)
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Use MACRO: Executing RoMScript "GetNumPartyMembers()".
Fight finished. Killed 3 Screaming Gargoyle. (fight #3 / runtime 2 minutes)
Durability: 99.991596638655
Paused. (Delete) to continue, (CTRL+L) exit to shell, (CTRL+C) quit

[dejfit]

My golden egg bot works fine fo over 12h (Big thx for that!) but when i tried run Blinsik daily quest bot it crashes every 2-10 minutes. I don not know if this is a bot issue or the waypoints...

[bokagavrilov]

macros will be back in next patch just go read http://www.solarstrike.net/phpBB3/viewt ... =21&t=3004 ::P