Targeting and useful staff (AutoTrade+AutoCollect 21.10.10)

[matt87]

_/_/_/_/_/_/ _/_/_/ _/_/_/ _/_/_/ _/ AutoTrade _/_/_/_/_/_/ _/_/_/ _/_/_/ _/_/_/ _/

At the begining you have to set few variables in script (waypoint file):

1. 1) seller
   If you'll set local seller = true, script will work normally. Auto-agree for trades, put items from selected indexes into trade window and accept trade if proper amount of money has been entered.
   Otherwise If we set local seller = false, character will agree all trades and accept them automatically.

• 2) TradeMoney
  local TradeMoney = 1 it's amount of money you want to earn from selling one item (i.e. 99xGolden Egs - it's still one item). Yeahh, its just a price.

• 3) L_Nr
  local L_Nr=1 it's index of item in bag from which we want to start selling items

• 4) U_Nr
  local U_Nr=5 - index of item to which AutoTrade will sell items.

Indexes in 1st and 2nd bag tabs :



_/_/_/_/_/_/ _/_/_/ _/_/_/ _/_/_/ _/ Download _/_/_/_/_/_/ _/_/_/ _/_/_/ _/_/_/ _/

(HastenRom)AutoTradeV1.4.xml

(2.81 KiB) Downloaded 303 times

(HastenRom)AutoCollectTradeV1.1.xml

(1.35 KiB) Downloaded 276 times

_/_/_/_/_/_/ _/_/_/ _/_/_/ _/_/_/ _/_/ Logs _/_/_/_/_/_/ _/_/_/ _/_/_/ _/_/_/ _/_/

• » 21.10.10 - AutoCollectTradeV1.1 added - just post for any question.

• » 21.10.10 - Nil bug fix.

• » 10.10.10 - Another nil bug fix, hope the last one.

• » 09.10.10 - Fixed issue with nil variable (Line:15,68 - AutoTradeV1.2)

• » 09.10.10 - Added seller mode (AutoTradeV1.1)

1. » 09.10.10 - First AutoTrade relase

_/_/_/_/_/_/ _/_/_/ _/_/_/ _/_/_/ _/ Features _/_/_/_/_/_/ _/_/_/ _/_/_/ _/_/_/ _/

AutoTrade

1. » Spam at zone channel, intoduction/info for ppl starting trade

1. » Follow mode if seller=false (+ if bag full - change waypoint)

• » Support, fixes and more for AutoTrade

AutoHeal

1. » Alpha tests

===============================================
Hello !

I couldnt figure out how to check:

- who's targetting me,
- target (select) player by his id or name (not a party way),
- if dialog window appears (ie exchange),
- target of another player

Thanks for tips!

[matt87]

Okey after few hours ...

Code: Select all

<?xml version="1.0" encoding="utf-8"?><waypoints>

   <!-- #  1 --><waypoint x="-2024" z="4904">	
   changeProfileOption("ANTI_KS", false)
      
   RoMScript("TargetUnit('party1');") 
   player:update();
   local target = player:getTarget();
   yrest(200) 
   
   cprintf(cli.red, language[5], "\n Lets rock! \n");
   while (true) do   
		// target:update() ?
   
        if target:getTarget().Address ~= 0 then 
		    cprintf(cli.yellow, language[5], "\n We have target selected \n");
			if target:getTarget().Address == player.Address then 
				cprintf(cli.yellow, language[5], "\n " .. target.Name .. " targeted us.\n");
				
				// ToDo
				
			end	
		else
			cprintf(cli.yellow, language[5], "\n Retargeting... \n");
			RoMScript("TargetUnit('party1');") 
			yrest(100) 
			player:update();
			yrest(100) 
			local target = player:getTarget();
		end
		yrest(2000)
   end
   
   </waypoint>
   
</waypoints>

Now I need little help how turn off Anti-KS permanently? While I use changeProfileOption("ANTI_KS", false) rombot still remove/uncheck/drestroy the target variable, because all the time hes trying to retarget (cprintf(cli.yellow, language[5], "\n Retargeting... \n");)

Of course, I can write code in the other way:

Code: Select all

<?xml version="1.0" encoding="utf-8"?>
<waypoints>
	
   <!-- #  1 --><waypoint x="-2024" z="4904">	
   changeProfileOption("ANTI_KS", false)
   cprintf(cli.yellow, language[5], "\n Lets rock! \n");

   while (true) do   

        RoMScript("TargetUnit('party1');") 
		yrest(100) 
		player:update();
		yrest(100) 
		local target = player:getTarget();
		yrest(100)

        if target:getTarget().Address == player.Address then 
		    cprintf(cli.yellow, language[5], "\n " .. target.Name .. " targeted us.\n");
                    // todo
        end	
		yrest(2000)
   end
   
   </waypoint>

</waypoints>

BTW, in that case we only 'fight' with Anti-KS. Throuth it will work for execute todo code, it still be better to turn off it.
Any ideas?

Anway, how I can obtain list of players/mobs actually targetting me ? Is it possible? (like mobs in threatmeter).

[Administrator]

Now I need little help how turn off Anti-KS permanently? While I use changeProfileOption("ANTI_KS", false) rombot still remove/uncheck/drestroy the target variable, because all the time hes trying to retarget (cprintf(cli.yellow, language[5], "\n Retargeting... \n");)

What does that have to do with ANTI_KS? Your code logic is highly flawed, so I'm not even sure what you're trying to do. Your confusing description doesn't help.

BTW, in that case we only 'fight' with Anti-KS. Throuth it will work for execute todo code, it still be better to turn off it.
Any ideas?

What?

Anway, how I can obtain list of players/mobs actually targetting me ? Is it possible? (like mobs in threatmeter).

Code: Select all

local objectList = CObjectList();
local aggroList = {};
objectList:update();

for i = 0,objectList:size() do
  local obj = objectList:getObject(i);

  if( obj == nil ) then
    break;
  end

  if( obj.Type == PT_MONSTER ) then
    if( obj.TargetPtr == player.Address ) then
      -- It is an enemy and has us targeted, so put it in the list
      table.insert(aggroList, CPawn(obj.Address));
    end
  end
end


-- aggroList is now a table of pawns that have us targeted.

[matt87]

Thank you for reply and aggro code

I'll try to explain more accurately. If I'll use changeProfileOption("ANTI_KS", false) (or add option in profile file) I still obtain message, that selected target is ignored by Anti-KS. Why (I turned it off) ?

You have right, there was mistake in code, but now I checked evrything and wrote comments to make it clearer.

Code: Select all

<?xml version="1.0" encoding="utf-8"?><waypoints>
   <!-- #  1 --><waypoint x="-2024" z="4904">   
   
   
   changeProfileOption("ANTI_KS", false) -- turn off Anti-KS ??? (still leave messages)
     
   RoMScript("TargetUnit('party1');")  -- select 1st (not us) person in party (works)
   player:update(); -- we have to update player struct to get the right target (works)
   
   local target = player:getTarget(); -- get the target (works, but after that using
									  -- player:haveTarget() returns always false
									  -- Anti-KS still work even we turnd off them ??
						
						
						
   -- PART FOR TESTING ====================================== 
   cprintf(cli.yellow, language[5], "UnitGUID:\n");
   if RoMScript("UnitGUID('target');") ~= 0 then
        cprintf(cli.yellow, language[5], "true");
   else
        cprintf(cli.yellow, language[5], "false");
   end -- return true
   
   cprintf(cli.yellow, language[5], "player haveTarget:\n");   
   if player:haveTarget() then
        cprintf(cli.yellow, language[5], "true");
   else
        cprintf(cli.yellow, language[5], "false");
   end -- return false
   -- PART FOR TESTING ====================================== 
   
   
   while (true) do   
		-- if player:haveTarget() then  -- check if the target is still selected (always FALSE, even target is selected in game )
		if RoMScript("UnitGUID('target');") ~= 0 then -- instead above line ( true if selected in game )
		    target:update() -- update target struct to check next statement
			if target:getTarget().Address == player.Address then
				cprintf(cli.yellow, language[5], "\n " .. target.Name .. " targeted us.\n");
				-- message above still with Anti-KS message (ignoring target)
				-- ToDo code... (i.e. AgreeTrade() -> yrest -> AcceptTrade() yrest -> AcceptTrade() 
			        -- or stop/start follow, etc...
			end   
		else -- select target again
			cprintf(cli.yellow, language[5], "\n Retargeting... \n");
			RoMScript("TargetUnit('party1');")
			player:update();
			local target = player:getTarget();
      end
      yrest(2000)
   end
   
   </waypoint>
</waypoints>

Even that part of code is not the best way to start trade or smth else (I hope that conversation will help some1, not only me) with other char, how I can turn off Anti-KS ? (and still have target using local target = player:getTarget(); -> player:haveTarget() )

I found a better way for auto-trading, I'll post it asap...

[matt87]

Finally, I finished the code. Enjoy! Auto-trading:

Code: Select all

<?xml version="1.0" encoding="utf-8"?><waypoints><onLoad>

	changeProfileOption("ANTI_KS", false)
	local B_used=0;
	local B_curr=0;
	local RecipientName, ItemInfo;
	local TradeMoney = 1; -- Recipient Money (cash you want earn)
	local L_Nr=1          -- First item index in bag which we want to sell
	local U_Nr=3		  -- Last item index in bag

	
	while (true) do 
	
		if string.len(RoMScript("GetTradeRecipientName();")) > 3 then
			-- Check the current number of items in bag 
			if RoMScript("GetBagCount();") ~= nil then
				B_used =  RoMScript("GetBagCount();")
			else
				cprintf(cli.red, "\n B_used = nil - break the loop " );
				break;
			end
			
			-- Save recipient name as variable (required to accept trade)
			RecipientName = RoMScript("GetTradeRecipientName();")
			cprintf(cli.yellow, "\nTradeing with " .. RecipientName);
			RoMScript("AgreeTrade();")		
			yrest(500) -- Im not sure its enough, you can increse it (depend on lag ms)
			
			-- Get the bag item at index L_Nr and put into trade at index 1
			ItemInfo = RoMScript("GetBagItemInfo("..tonumber(L_Nr)..");")
			RoMScript("PickupBagItem("..tonumber(ItemInfo)..");")
			yrest(400)
			RoMScript("ClickTradeItem(1);")
			yrest(200)
			
			-- Accept trade if recipient put the required money
			while string.len(RoMScript("GetTradeRecipientName();")) > 3 do		
				if RoMScript("GetTradeTargetMoney();") >= TradeMoney then
					RoMScript("AcceptTrade('..RecipientName..');")
					yrest(200)
				end	
			end
			
			-- Check if items quantity in bag (if changed item sold) > 0
			B_curr = RoMScript("GetBagCount();")
			if B_curr ~= nil then
				if B_used > B_curr then
				    cprintf(cli.yellow, "\nItem sold " );
					L_Nr = L_Nr+1;
				end
			else
			    cprintf(cli.red, "\n B_curr = nil - break the loop " );
				break;
			end
			
			-- If all items are sold than stop the loop 
			if L_Nr==U_Nr+1 then
				break;
			end
		end
				
		yrest(1000)
	end
	
	cprintf(cli.green, "\nAll items are sold " );
	stopPE()
	
</onLoad></waypoints>

If you'll get any error don't hesitate to post about it. Any ideas are welcome.

BTW, still have few questions:
- How to turn off Anti-KS permanently (I wont get Anti-Pk messages using player:getTarget() and destroyed variable) ?
- How force the character to not move from place, just standing after start?

Another think is that I have problem with statement:
if RoMScript("GetTradeRecipientName();") ~= nil and string.len(RoMScript("GetTradeRecipientName();")) > 3 then
sometimes return error, about that nil is compare with a number, but how if first part of statement excludes that, am I right? Maybe thers another way to avoid that ?

[Administrator]

I don't follow. You have turned ANTI_KS off permanently. That is not the problem. And player:haveTarget() does work just fine when ANTI_KS is disabled. Most likely, your problem lies somewhere else (ie. level difference or something).

Since you don't actually want to check if the target is valid for attacking (which haveTarget() does), you should, instead, be checking the return value of getTarget().

Code: Select all

local playerTarget = player:getTarget();

if( playerTarget ) then
  -- we have a target
else
  -- we do not have any target
end

[matt87]

Thanks! I should look more at rom bot functions.

Code: Select all

   -- PART FOR TESTING ======================================
   cprintf(cli.yellow, language[5], "UnitGUID:\n");  -- 1st 
   if RoMScript("UnitGUID('target');") ~= 0 then
        cprintf(cli.yellow, language[5], "true");
   else
        cprintf(cli.yellow, language[5], "false");
   end -- return true
   
   cprintf(cli.yellow, language[5], "player haveTarget:\n");   -- 2nd
   if player:haveTarget() then
        cprintf(cli.yellow, language[5], "true");
   else
        cprintf(cli.yellow, language[5], "false");
   end -- return false
   -- PART FOR TESTING ======================================  

That's why player:haveTarget() returns always false in that case. Because he's looking for valid attackable target. So, not player, just monster. Am I right ?

[rock5]

Another think is that I have problem with statement:
if RoMScript("GetTradeRecipientName();") ~= nil and string.len(RoMScript("GetTradeRecipientName();")) > 3 then
sometimes return error, about that nil is compare with a number, but how if first part of statement excludes that, am I right? Maybe thers another way to avoid that ?

Because any RoMScript command can mistakenly return a nil, the second RoMScript above can return a nil when the first doesn't. Try using a variable instead and call RoMScript only once.

Code: Select all

recipient = RoMScript("GetTradeRecipientName();")
if recipient ~= nil and string.len(recipient) > 3 then

[checkii]

Hello,

Is it possible run this script with waypoints? It seems that the while statements makes everything loop so the bot cannot move on.

Am I missing something? This script would be awesome if it worked as part of a waypoint system.

[rock5]

Hello,

Is it possible run this script with waypoints? It seems that the while statements makes everything loop so the bot cannot move on.

Am I missing something? This script would be awesome if it worked as part of a waypoint system.

I think you are missing something. The point of my script is to automate attacking, healing etc. when you are moving around yourself. The point of a follow and assist script is that it follows another character. Neither of these situations require waypoints.

If what you are saying is want the assist character to follow the main character along a waypoint path then I guess what you would do is run a regular waypoint file with the main character and a follow and assist script on the assisting character.

[matt87]

checkii I really don't know why you want to do that. My idea of AutoTrade is to leave character in one place, which will be spamming at zone channel (i.e. evry 15min) about selling posibility and sells items. So, I dont have to pay fee in AH.
Well, If u want do that, you should remove onload at the begining and make few changes:

Code: Select all

<!-- #  1 -->
<waypoint tag="selling">
(...)
changeProfileOption("HARVEST_DISTANCE", 40)
changeProfileOption("ANTI_KS", false)
changeProfileOption("PATH_TYPE", "wander")
changeProfileOption("WANDER_RADIUS", 0)
changeProfileOption("AUTO_TARGET", false)
changeProfileOption("USE_SLEEP_AFTER_RESUME", true)
(...) 
while (true) do 
if player.Battling then
	RoMScript("TargetUnit('party1');") 
	-- use heal skills?
else
	RoMScript("FollowUnit('party1');")
	-- add distanse or smth else..
end
(...)
</waypoint>

You can load this waypoint using: __WPL:setWaypointIndex(__WPL:findWaypointTag("selling"));
I'll think to add follow mode posibility, it could be usefull for not seller mode - mean just follow and accept trades from other character. May little assist if character is healer.

[checkii]

Waypoints for the receiver will help once his inventory is full. Then he can take waypoints to sell/mail items then return to a rally point so he can continue receiving items.

I realize this is meant for actual auctions and selling items. But with waypoints he becomes more of a mule, a mobilized bank. If he follows a main character around then he is just an extension of the main characters inventory.

If I can setup up a waypoint system I can have my own walking merchant.

[Immortal]

hey guys thanks for that script. this is nearly what i need for my next bot

i need a character to just accept trades. It works the first time ... but when the trade is over micromacro still says "Trading with 'Characktername'. "
how can i get it to recognize the trade is over and it has to wait for the next one? because the second time i trade my character he wont accept anymore because micromacro dont recognize

[matt87]

Code: Select all

<?xml version="1.0" encoding="utf-8"?><waypoints><onLoad>

    changeProfileOption("ANTI_KS", false)
    changeProfileOption("PATH_TYPE", "wander")
    changeProfileOption("WANDER_RADIUS", 0)
    changeProfileOption("AUTO_TARGET", false)
    changeProfileOption("USE_SLEEP_AFTER_RESUME", true)
    
    local B_used=0;
    local B_curr=0;
    local RecipientName, ItemInfo;
    local seller = false; -- set to 'false' if u just want to accept trade (not sell items)
    local TradeMoney = 199000; -- Recipient Money (cash you want earn)
    local L_Nr=1          -- First item index in bag which we want to sell
    local U_Nr=24          -- Last item index in bag

    if seller then    
        while (true) do 
            yrest(1000)
            RecipientName = RoMScript("GetTradeRecipientName();")
            if RecipientName == nil then
            elseif RecipientName == "" then
            else
                
                -- Check the current number of items in bag 
                if RoMScript("GetBagCount();") ~= nil then
                    B_used =  RoMScript("GetBagCount();")
                else
                    cprintf(cli.red, "\n B_used = nil - break the loop " );
                    break;
                end
            
                -- Save recipient name as variable (required to accept trade)
                RecipientName = RoMScript("GetTradeRecipientName();")
                cprintf(cli.yellow, "\nTradeing with " .. RecipientName);
                RoMScript("AgreeTrade();")        
                yrest(500) -- Im not sure its enough, you can increse it (depend on lag ms)
            
                -- Get the bag item at index L_Nr and put into trade at index 1
                ItemInfo = RoMScript("GetBagItemInfo("..tonumber(L_Nr)..");")
                RoMScript("PickupBagItem("..tonumber(ItemInfo)..");")
                yrest(400)
                RoMScript("ClickTradeItem(1);")
                yrest(200)
            
                -- Accept trade if recipient put the required money
                while TradeMoney >= RoMScript("GetTradeTargetMoney();") do
                    RoMScript("AcceptTrade('..RecipientName..');")
                    yrest(200)
                end    
    
            
                -- Check if items quantity in bag (if changed item sold) > 0
                B_curr = RoMScript("GetBagCount();")
                if B_curr ~= nil then
                    if B_used > B_curr then
                        cprintf(cli.yellow, "\nItem sold " );
                        L_Nr = L_Nr+1;
                    end
                else
                    cprintf(cli.red, "\n B_curr = nil - break the loop " );
                    break;
                end
            
                -- If all items are sold than stop the loop 
                if L_Nr==U_Nr+1 then
                    break;
                end
            end
        end
        cprintf(cli.green, "\nAll items are sold " );
    else
        while (true) do 
            yrest(200) 
            RecipientName = RoMScript("GetTradeRecipientName();")
            if RecipientName == nil then
            elseif RecipientName == "" then
            else
                RoMScript("AgreeTrade();")        
                yrest(1200) 
                while RoMScript("GetTradeTargetItemInfo(1)") ~= nil do
                    RoMScript("AcceptTrade('..RecipientName..');")
                    yrest(500)
                    RoMScript("AcceptTrade('..RecipientName..');")
                end
            end
        end
    end
    
    stopPE()
    
</onLoad></waypoints>

If you will set local seller = false, character will start accept trades if theres any item at 1st recipient (target) slot.


Here's another useful script:
--AutoCollectTrade v1.1

Code: Select all

<?xml version="1.0" encoding="utf-8"?><waypoints><onLoad>
local qua=0
changeProfileOption("HARVEST_DISTANCE", 40)
changeProfileOption("ANTI_KS", false)
changeProfileOption("PATH_TYPE", "wander")
changeProfileOption("WANDER_RADIUS", 0)
changeProfileOption("AUTO_TARGET", false)
changeProfileOption("USE_SLEEP_AFTER_RESUME", true)

while (true) do 

    while (true) do
        if player:harvest(222222) then -- item id to collect example
            yrest(3600)
        elseif player:harvest(222222) then
            yrest(3600)
        end
        
        qua = tonumber(RoMScript("GetBagItemCount(111111);")) -- item it in bag example
        if qua == nil then
            elseif qua > 9 then
                cprintf(cli.yellow, "\ngot it " .. qua);
            break;
        end
    end
    yrest(400)
    
    RoMScript("RequestTrade('party1');")
    yrest(2000)
    ItemInfo = RoMScript("GetBagItemInfo(1);")
    RoMScript("PickupBagItem("..tonumber(ItemInfo)..");")
    yrest(500)
    RoMScript("ClickTradeItem(1);")
    yrest(800)
    RoMScript("AcceptTrade('charater_name_who_give_us_trade');") -- change this !
    yrest(500)
    RoMScript("AcceptTrade('i.e._2nd_char');") -- change this !
    yrest(200)



end

</onLoad></waypoints>

Remmember that person u want to trade (you want send request trade) must be in party at 1st position. ( RequestTrade('party1') ),

Resume, 1st char - allways accept trade, if therest item at 1st slot, click confirm. 2nd char, collect items, if quantity is enough, give trade request to 1st char and complete trade. Remmmber that collecting item must be in 1st bag slot.

Best regards
HastenRom

[OneofMany]

Found this thread very interesting:
What i can think of is, if you have an account making fusion stones, let that character finish all stones, walk to a house where the "receiver" is, trade it, walk back to starting point, login next character and so on...

Would this be possible with this script?

[lisa]

Lol I started reading this topic from the top and then realized the dates were a year ago.

Why don't you just mail them?

[OneofMany]

Because mailing gets logged by froggy, and trading seems to me the safest (its an amount that will be seen if logged)

[lisa]

trades are also logged.

You can test this, do a trade with someone, even between 2 of your own chars. Trade something for gold but give yourself 10% of real value.

so say you sell a stat to yourself, price is usually 2mil, trade yourself 200,000

Contact a GM and say you think they didn't trade you enough gold and say the other person isn't sure either. Ask then GM to check the transaction.

They should be able to say that you traded 200k gold.

dropping a 0 is an honest mistake and shouldn't get you added to a watch list, so you know say your sorry and blah blah then trade the difference.