Lags / Freeze when looting is enabled

[jonklaas]

Hi,

when looting es enabled the bot (Mircomacro) takes, directly after killing a mob, a high CPU load and my system.
At this peak the pc is frozen for 1 - 2 seconds, not all the time but on average every second kill.
Then at long lags looting fails, without looting I dont have those lags.

I have a Core2duo at 3,5 Ghz, 4 Gb Ram, GTX 260, Win7, SVN-Version 5.16.
When I trie to set the process priority for mircomarco lower it gives me an error.

Anybody elso getting those lags? Is this normal?

[Administrator]

No, that doesn't sound normal. First, can you confirm that micromacro.exe is the process using up your processor during this time (watch the Task Manager for this)?

Open up rom/classes/player.lua in notepad and go to (CTRL+G) line 1188. You'll see this:

Code: Select all

		while target.Lootable == true and deltaTime(getTime(), startWait) < maxWaitTime do
			inventory:updateSlotsByTime(100)
			target:update()
		end

Under 'target:update()' and above 'end', add this:

Code: Select all

yrest(1);

Does this alleviate the problem?

[wizzyslo]

I had same problem for long time and I didn't use bot for long time. This problem happend after new updating invenotry, I was testing this yrest(1) in inventory.lua and found that function CInventory:updateNextSlot(_times) doing problems.
I added only yrest(1) on line 299 that is it works normal now

Code: Select all

-- update x slots
function CInventory:updateNextSlot(_times)

	if(not _times) then _times = 1; end
	yrest(1);
	for i = 1, _times do
		local item = self.BagSlot[self.NextItemToUpdate];

--		if( settings.profile.options.DEBUG_INV) then
--			local msg = "";
--			msg = "DEBUG updateNextSlot(): Slot #"..self.NextItemToUpdate..": ";
--			if(item.Name) then
--				msg = msg.." name "..item.Name;
--			else
--				msg = msg.." name ".." <Slot Empty>";
--			end;
--			if(item.ItemCount) then msg = msg.." ItemCount:"..item.ItemCount; end;
--			cprintf(cli.lightblue, "%s\n", msg);
--		end;

		self.BagSlot[self.NextItemToUpdate]:update();
		self.NextItemToUpdate = self.NextItemToUpdate + 1;
		if (self.NextItemToUpdate > self.MaxSlots) then
			self.NextItemToUpdate = 1;
		end;

	end;
end;

[Administrator]

That can't be right. Are you sure that's what you've got? If anything, I expect it should need to be inside the for loop, not above it.

[wizzyslo]

I tested little more and I found somthing else. Its not important where is yrest(1) in CInventory:updateNextSlot(_times) but need to be there to fix my problem.

Rly dont ask me whay there becouse i'm not good with those functions and in programing.

If anybudy else with same problem test it pls and tell if works.