3.0.4 problem again :)

[MiesterMan]

I'm gonna make a new thread for this but the issue he mentioned above is unfortunately not with autorelog. This is the 15th time it randomly happened in the same place in my script. I have another script runnning the exact same thing that goes fine but at this waypoint on one of my consoles it does this...

Code: Select all

We try to find NPC QuestLady: Use MACRO: Executing RoMScript "OnClick_QuestListButton(1,1);".
Use MACRO: Executing RoMScript "AcceptQuest();".
Use MACRO: Executing RoMScript "OnClick_QuestListButton(3,1);".
Use MACRO: Executing RoMScript "CompleteQuest();".
Use MACRO: Executing RoMScript "CloseWindows();".
Clearing target.
Moving to waypoint #2, (31784, 4605)
Moving to waypoint #3, (31795, 4711)
Moving to waypoint #4, (31853, 4973)
Moving to waypoint #5, (31430, 5705)
Moving to waypoint #6, (31420, 5722)
Moving to waypoint #7, (31420, 5722)
We found Scooby Snack and will harvest it.
Clearing target.
Moving to waypoint #8, (31917, 4808)
scripts/rom/classes/pawn.lua:184: bad argument #1 to 'bitAnd' ((null))

[Administrator]

So you actually going to give a detailed explanation of what happened, or are you want us to read your mind?
You need to provide information such as how often it happens, when it happens, where it happens, whether it only happens with certain sets of waypoints or not, whether it only happens on certain characters or not, and any other potentially useful information.

[rock5]

scripts/rom/classes/pawn.lua:184: bad argument #1 to 'bitAnd' ((null))[/code]

Hm... I don't normally respond to threads about these bitAnd errors because I've never encountered them myself but I've made some observations about this one.

The code in question is this;

Code: Select all

	self.Lootable = debugAssert(memoryReadInt(proc, self.Address + addresses.pawnLootable_offset), memerrmsg);
	if( self.Type == 2 ) then
		--printf("%s Lootable flag: 0x%X (%d)\n", self.Name, self.Lootable, self.Lootable);
	end
	self.Lootable = bitAnd(self.Lootable, 0x4);

So what the error means is sometimes the first line returns nil. I'm not sure what could cause a memory read to return nil. Maybe running too many clients at once causes this but that is just speculation?

A thought comes to mind, though, why use a bit wise operation at all? Why not just use memoryReadByte?

[Administrator]

A thought comes to mind, though, why use a bit wise operation at all? Why not just use memoryReadByte?

Because of the way flags work. If we need to check for a flag (0x2) being set, the number could be 0x2 or 0x3, or... any number of combinations and still be set. It's much easier to use bitwise operations to check for this rather than a huge number of conditions.

Anyways, it doesn't mater. The problem here is that the memory reading is failing for some reason, not the bitAnd() function.

[net_ralf]

My solution for my problem leave you pc off for one night and then it works lol

[swietlowka]

best way to solve it would be to add that when this bitand is null the bot waits for for example 5s, cause from my observation its something with the memory reading and if you just start it right after error it works again with no problem

[rock5]

A thought comes to mind, though, why use a bit wise operation at all? Why not just use memoryReadByte?

Because of the way flags work. If we need to check for a flag (0x2) being set, the number could be 0x2 or 0x3, or... any number of combinations and still be set. It's much easier to use bitwise operations to check for this rather than a huge number of conditions.

Anyways, it doesn't mater. The problem here is that the memory reading is failing for some reason, not the bitAnd() function.

Ah yes, I'm showing my ignorance again. A byte is not a bit. You still need to get the bit. There is no memoryReadBit. LoL

Anyway, couldn't we just say after the memory read "if Lootable == nil then Lootable = false"?

Also, I don't understand how Lootable is being used.
Doesn't

Code: Select all

   self.Lootable = bitAnd(self.Lootable, 0x4);

mean that self.Lootable will equal 0 or 4?

And doesn't that mean

Code: Select all

if target.Lootable then

will always return true?

Maybe it's supposed to be

Code: Select all

   self.Lootable = bitAnd(self.Lootable, 0x4) == 0x4;

That way you get a true or false value.

And yet it seems to work anyway.

[Administrator]

Also, I don't understand how Lootable is being used.
Doesn't

Code: Select all

   self.Lootable = bitAnd(self.Lootable, 0x4);

mean that self.Lootable will equal 0 or 4?

Nope. It returns if the flag stored at 0x4 is on or off.


We could assume false if there is a problem reading memory, but it's best to figure out why it's failing to begin with. There's about a million different things that I can think of that could cause that, but, as of yet, nobody has provided enough information to even begin to understand what the problem is.

[rock5]

Nope. It returns if the flag stored at 0x4 is on or off.

But what value does it return? What value does Lootable have if the target is lootable or not lootable?

[MiesterMan]

Sorry, started a new thread for it here.

[Cookie]

Hello, i have the same Prob like net_ralf.

...macro/micromacro/scripts/rom/classes/memorytable.lua:37: attempt to compare number with nil

I reinstalled, updated and checked all, any Idea?

[rock5]

Hello, i have the same Prob like net_ralf.

...macro/micromacro/scripts/rom/classes/memorytable.lua:37: attempt to compare number with nil

I reinstalled, updated and checked all, any Idea?

That just happened to me. Don't know what caused it but restarting the game fixed it.

[botje]

works fine for me O.o

no errors seen after patch.

Botje

[rock5]

Damn! Happened again, and this time it was right after starting the game. Again, restarting the game fixed it.

Weird, I hope this doesn't become a common occurrence.

[Cookie]

Hi!

Restarting the Game didnt fix my problem :/ any other Ideas?