774 Changelog

For changelogs and discussion related to a specific revision.
Message
Author
User avatar
rock5
Posts: 12173
Joined: Tue Jan 05, 2010 3:30 am
Location: Australia

774 Changelog

#1 Post by rock5 » Wed May 14, 2014 4:53 am

  • - If a userfunction forces an early setupMacros then it will print a warning message telling you which userfunction.
    - Simplified autosell with the new unlimited length RoMScripts.
    - itemtypes are now gotten from memory so is about 15 times faster.
    - Fixed bug that caused the bot to break heal at end of fights.
    - RoMScript can now accept any length command.
    - Added function tableToString for use in moving tables into the game.
    - RoMScript can now also return table values.

    - If the code you send in RoMScript errors it now returns the actual error and instead of just saying

    Lisas changes:
    - Added party profile option MONITOR_WHISPERS.
    - Added "party" skill type for skills.xml database.
    - player:findNearestNameOrId now also returns a sorted table of all the found objects as a second returned value.
There were a few other minor changes not worth mentioning or I forgot what they fixed. :oops:
  • Please consider making a small donation to me to support my continued contributions to the bot and this forum. Thank you. Donate
  • I check all posts before reading PMs. So if you want a fast reply, don't PM me but post a topic instead. PM me for private or personal topics only.
  • How to: copy and paste in micromacro
    ________________________
    Quote:
    • “They say hard work never hurt anybody, but I figure, why take the chance.”
          • Ronald Reagan

User avatar
lisa
Posts: 8332
Joined: Tue Nov 09, 2010 11:46 pm
Location: Australia

Re: 774 Changelog

#2 Post by lisa » Wed May 14, 2014 5:41 am

rock5 wrote:- player:findNearestNameOrId now also returns a sorted table of all the found objects as a second returned value.
I had completely forgotten about that 1, I must be getting old.
Remember no matter you do in life to always have a little fun while you are at it ;)

wiki here http://www.solarstrike.net/wiki/index.php?title=Manual

User avatar
rock5
Posts: 12173
Joined: Tue Jan 05, 2010 3:30 am
Location: Australia

Re: 774 Changelog

#3 Post by rock5 » Wed May 14, 2014 7:09 am

As I was going through the list I remembered that one was yours. Still, had to check on the forum to be sure. :)
  • Please consider making a small donation to me to support my continued contributions to the bot and this forum. Thank you. Donate
  • I check all posts before reading PMs. So if you want a fast reply, don't PM me but post a topic instead. PM me for private or personal topics only.
  • How to: copy and paste in micromacro
    ________________________
    Quote:
    • “They say hard work never hurt anybody, but I figure, why take the chance.”
          • Ronald Reagan

ZZZZZ
Posts: 513
Joined: Sun Oct 21, 2012 1:42 am

Re: 774 Changelog

#4 Post by ZZZZZ » Wed May 14, 2014 8:33 am

Just to make sure, the range of the 'party' skills didn't need to be changed from 0 to 100 did they?

User avatar
lisa
Posts: 8332
Joined: Tue Nov 09, 2010 11:46 pm
Location: Australia

Re: 774 Changelog

#5 Post by lisa » Wed May 14, 2014 6:05 pm

ZZZZZ wrote:Just to make sure, the range of the 'party' skills didn't need to be changed from 0 to 100 did they?
I would say they probably do need to be made to 100 =(
Remember no matter you do in life to always have a little fun while you are at it ;)

wiki here http://www.solarstrike.net/wiki/index.php?title=Manual

User avatar
lisa
Posts: 8332
Joined: Tue Nov 09, 2010 11:46 pm
Location: Australia

Re: 774 Changelog

#6 Post by lisa » Wed May 14, 2014 8:46 pm

well good news is that the skills are cast on player still, so it is behaving exactly as it did before this update, when ranges are changed to 100 then it will do as we intended it to do.
Remember no matter you do in life to always have a little fun while you are at it ;)

wiki here http://www.solarstrike.net/wiki/index.php?title=Manual

ZZZZZ
Posts: 513
Joined: Sun Oct 21, 2012 1:42 am

Re: 774 Changelog

#7 Post by ZZZZZ » Wed May 14, 2014 9:39 pm

Uhh now im lost....something broke with that revision.

Code: Select all

if _skill.Available and _skill.Type == STYPE_BUFF and _skill.BuffName ~= "" and _skill.Target == STARGET_PARTY then
That now returns negative where as before with the exact same buffs it was all true and hence worked how I wanted it to :S

ZZZZZ
Posts: 513
Joined: Sun Oct 21, 2012 1:42 am

Re: 774 Changelog

#8 Post by ZZZZZ » Wed May 14, 2014 9:46 pm

Ran this function:

Code: Select all

function ZZtestt()
	for i,v in pairs(settings.profile.skills) do
		if v.Target == STARGET_PARTY then
			print(v.Name .. " = party buff")
		else
			print(v.Name .. " is not a party buff")
		end
	end
end
This was the result:

Code: Select all

Type in 'q' (without quotes) to quit.
Command> ZZtestt()
ALL_FIRE_TRAINING is not a party buff
WARRIOR_LIGHTNINGS_TOUCH is not a party buff
MAGE_FIREBALL is not a party buff
ALL_SOLDIERS_ATTACK is not a party buff
WARRIOR_LIGHTNING_BURN_WEAPON is not a party buff
WARDEN_POWER_OF_THE_WOOD_SPIRIT is not a party buff
WARDEN_CHARGED_CHOP is not a party buff
WARDEN_BRIAR_SHIELD is not a party buff
WARRIOR_SURPRISE_ATTACK is not a party buff
WARRIOR_ELECTRICAL_RAGE is not a party buff
MAGE_LIGHTNING is not a party buff
PRIEST_MAGIC_BARRIER is not a party buff
Command>
PRIEST_MAGIC_BARRIER should have come up as a party buff.

Code: Select all

<skill name="PRIEST_MAGIC_BARRIER"					id="491472" range="100"	type="buff"			casttime="0"	cooldown="0"	target="party" 		buffname="501877" />

User avatar
lisa
Posts: 8332
Joined: Tue Nov 09, 2010 11:46 pm
Location: Australia

Re: 774 Changelog

#9 Post by lisa » Wed May 14, 2014 9:55 pm

looks like database.lua was missing from the commit, I have reverted all my files so I lost those changes, hopefully I posted it on the forum somewhere.
Remember no matter you do in life to always have a little fun while you are at it ;)

wiki here http://www.solarstrike.net/wiki/index.php?title=Manual

User avatar
lisa
Posts: 8332
Joined: Tue Nov 09, 2010 11:46 pm
Location: Australia

Re: 774 Changelog

#10 Post by lisa » Wed May 14, 2014 10:10 pm

I did post a database.lua, here it is, hopefully it was my final version.
Attachments
database.lua
(8.73 KiB) Downloaded 237 times
Remember no matter you do in life to always have a little fun while you are at it ;)

wiki here http://www.solarstrike.net/wiki/index.php?title=Manual

ZZZZZ
Posts: 513
Joined: Sun Oct 21, 2012 1:42 am

Re: 774 Changelog

#11 Post by ZZZZZ » Wed May 14, 2014 10:18 pm

Nope same deal, i'll grab my old database file and see if that works still.

Edit - Even that returned false....idk whats going on now :(
--
Ok its definitely to do with database.lua. Used my rev. 773 rombot and it worked fine, replaced the database.lua with the rev. 774 and it returned false.
--
ookkk....i should stop testing stuff, getting confused with what folder is what now >.< Putting your database.lua in the rev 773 folder worked, but then when i used the same database.lua in the rev 774 folder it didnt work :/

User avatar
lisa
Posts: 8332
Joined: Tue Nov 09, 2010 11:46 pm
Location: Australia

Re: 774 Changelog

#12 Post by lisa » Wed May 14, 2014 10:41 pm

hmm skill.lua was missing a line in the commit aswell.

STARGET_PARTY = 4


So basically without that STARGET_PARTY is nil and so you set all the .target = STARGET_PARTY to be nil.
skill.lua
(24.43 KiB) Downloaded 241 times
I really wish I didn't do a revert now =(
Remember no matter you do in life to always have a little fun while you are at it ;)

wiki here http://www.solarstrike.net/wiki/index.php?title=Manual

User avatar
rock5
Posts: 12173
Joined: Tue Jan 05, 2010 3:30 am
Location: Australia

Re: 774 Changelog

#13 Post by rock5 » Wed May 14, 2014 11:01 pm

I seem to have really stuffed that up. I think maybe it would have been a better idea if you had committed your own changes .
lisa wrote:I really wish I didn't do a revert now =(
Why? Did you make more changes after you posted those files? Or do you think you missed something?

So I see 2 lines to change 1 in skill.lua and 1 in database.lua.
  • Please consider making a small donation to me to support my continued contributions to the bot and this forum. Thank you. Donate
  • I check all posts before reading PMs. So if you want a fast reply, don't PM me but post a topic instead. PM me for private or personal topics only.
  • How to: copy and paste in micromacro
    ________________________
    Quote:
    • “They say hard work never hurt anybody, but I figure, why take the chance.”
          • Ronald Reagan

User avatar
lisa
Posts: 8332
Joined: Tue Nov 09, 2010 11:46 pm
Location: Australia

Re: 774 Changelog

#14 Post by lisa » Wed May 14, 2014 11:04 pm

rock5 wrote:Why? Did you make more changes after you posted those files? Or do you think you missed something?
because I have no idea what I did and didn't do, head is so full of goo =(
Those things are the only ones that really popped out as missing in the commit, could me more *shrug*
Remember no matter you do in life to always have a little fun while you are at it ;)

wiki here http://www.solarstrike.net/wiki/index.php?title=Manual

User avatar
lisa
Posts: 8332
Joined: Tue Nov 09, 2010 11:46 pm
Location: Australia

Re: 774 Changelog

#15 Post by lisa » Wed May 14, 2014 11:20 pm

database/skills.xml also needed changes for the range.
Attachments
skills.xml
(85.98 KiB) Downloaded 219 times
Remember no matter you do in life to always have a little fun while you are at it ;)

wiki here http://www.solarstrike.net/wiki/index.php?title=Manual

ZZZZZ
Posts: 513
Joined: Sun Oct 21, 2012 1:42 am

Re: 774 Changelog

#16 Post by ZZZZZ » Thu May 15, 2014 1:25 am

Yeh that is working now with the skill.lua change (sorry for late reply, downloaded it then went afk lol).

User avatar
rock5
Posts: 12173
Joined: Tue Jan 05, 2010 3:30 am
Location: Australia

Re: 774 Changelog

#17 Post by rock5 » Thu May 15, 2014 1:56 am

lisa wrote:database/skills.xml also needed changes for the range.
Oh yeah, and that too.
  • Please consider making a small donation to me to support my continued contributions to the bot and this forum. Thank you. Donate
  • I check all posts before reading PMs. So if you want a fast reply, don't PM me but post a topic instead. PM me for private or personal topics only.
  • How to: copy and paste in micromacro
    ________________________
    Quote:
    • “They say hard work never hurt anybody, but I figure, why take the chance.”
          • Ronald Reagan

ZZZZZ
Posts: 513
Joined: Sun Oct 21, 2012 1:42 am

Re: 774 Changelog

#18 Post by ZZZZZ » Thu May 15, 2014 3:17 am

Um ok, I am getting some odd error messages since the revision too, this is just running the same daily/mini loop that I have for months, nothing has changed. It sits there for up to a minute or 2, then prints what seems to be a random error then continues.

Code: Select all

[string "return {List_Item_OnEnter="function: 6C7068A8..."]:1: '}' expected near
 'Lakoso'

Code: Select all

Wave: 9, Score: 1983
Wave: 10, Score: 2405
Event finished, end score was 3099We try to find NPC 120687:
We successfully target NPC Magelly Basac and try to open the dialog window.
[string "return {_uilua.lightuserdate="userdata: 33B4D..."]:1: '}' expected near
 '='
Never seen those before, i'll try to see exactly where it does it and post and others I may see.

User avatar
lisa
Posts: 8332
Joined: Tue Nov 09, 2010 11:46 pm
Location: Australia

Re: 774 Changelog

#19 Post by lisa » Thu May 15, 2014 4:34 am

maybe something to do with how the romscripts are done?
Remember no matter you do in life to always have a little fun while you are at it ;)

wiki here http://www.solarstrike.net/wiki/index.php?title=Manual

User avatar
rock5
Posts: 12173
Joined: Tue Jan 05, 2010 3:30 am
Location: Australia

Re: 774 Changelog

#20 Post by rock5 » Thu May 15, 2014 4:58 am

It will obviously have something to do with the fact that RoMScript can return tables now. But you wouldn't be trying to return tables before because it wouldn't have worked. I think I would have to see your waypoint file to figure out what's happening.
  • Please consider making a small donation to me to support my continued contributions to the bot and this forum. Thank you. Donate
  • I check all posts before reading PMs. So if you want a fast reply, don't PM me but post a topic instead. PM me for private or personal topics only.
  • How to: copy and paste in micromacro
    ________________________
    Quote:
    • “They say hard work never hurt anybody, but I figure, why take the chance.”
          • Ronald Reagan

Post Reply

Who is online

Users browsing this forum: No registered users and 3 guests