RoM server Patch 4.0.3. - The Mighty Shield.

[lisa]

Hi Guys,

Thank you for all your work you do on this program.

I have a little problem with this update

the error
"THE ATTACK SKILL NEEDS TO BE IN THE ACTIONBAR AND HAVE A VALID HOTKEY"

In the macro's folder line 65

in game press k, now go to tab 1, skill top left of screen is attack. hold left click on it and drag it to the action bar.
Also make sure that where you put the skill it has a hotkey for it.
any of these are concidered valid.
1 2 3 4 5 6 7 8 9 0 - =

[FireWire]

Hi Guys,

Thank you for all your work you do on this program.

I have a little problem with this update

the error
"THE ATTACK SKILL NEEDS TO BE IN THE ACTIONBAR AND HAVE A VALID HOTKEY"

In the macro's folder line 65

Did you go into your profile and edit the keys? I just explained it and so have others... If so then make sure that skill is in the same exact slot on ure action bar that u specified

[BillDoorNZ]

I installed Extended Action Bar, and put the RB Command macro on that and bound the key to that slot. This pretty much removes the necessity to bind directly to keys. I also ended up having to move my Attack skill to the bar as well to fix an issue with the player:target_NPC function (it obviously needs to use the skill to open the npc dialog).

Only other change I had to make was to the macros.lua file to stop it scanning for the command macro, but rather use the key specified in my characters profile:

Code: Select all

function setupMacroHotkey()
	if (settings.profile.options.SETMACRO == true) then
		--just use the maco key as defined in profile.xml options.
		return;
	end;
	
	-- Find the action key that points to the command macro.
	local actionKey, hotkey = findActionKeyForMacro(commandMacro)
	if not actionKey then
		actionKey, hotkey = findUsableActionKey()
		if actionKey then
			setActionKeyToMacro(actionKey, commandMacro)
		else
			error("No valid action keys available for the command macro. Please supply an empty action key with a hotkey and no modifier.")
		end
	end

	if( settings.options.DEBUGGING_MACRO ) then
		printf("actionKey set to " .. actionKey .. ".\n")
		printf("The macro hotkey is ".. string.char(hotkey) .. ".\n")
	end

	-- Set settings.profile.hotkeys.MACRO.key
	settings.profile.hotkeys.MACRO.key = hotkey
end

All very hacky and temporary, but saves me having to modify my profiles extensively (rather I just add the following):

Code: Select all

		<option name="SETMACRO"        value="true" />

and have my macro hotkey specified - I use F10:

Code: Select all

	<hotkeys>
    	<!-- to communicate with the RoM API / define ingame dummy macro at place 1 -->
		<hotkey name="MACRO"        modifier="" key="VK_F10" />
	</hotkeys>

[lisa]

Yes as I said it can be done but a little tricky, I also said not to rush out and get the addon just yet.

Been looking into the addon and why it is monitoring whispers.
Only thing it is doing when your whispered is saving the character name of who whispered you to a global variable. I couldn't find anything in any of the files that uses the global for anything. Seems very odd, perhaps it is set up to work with other addons and eventually it collects more information for usage in one of the addons.
Here is the dodgy part of the code, arg4 is name of person whispering. lastRepeat and lastReply arn't used anywhere else in this addon but they are made global which means other addons can use that information.

Code: Select all

		if(event=="CHAT_MSG_WHISPER_INFORM" and type(arg4)=="string")then
			lastRepeat=arg4;
		elseif(event=="CHAT_MSG_WHISPER" and type(arg4)=="string")then
			lastReply=arg4;
		end

So like I said don't rush out and get the addon just yet.

--=== Edit ===--

Actually they are made local at the begining of the file. Still I don't understand why it is monitoring whispers.

Code: Select all

local lastReply="";
local lastRepeat="";

[Sabrinajewel]

Hi Guys

I did have the attack skill in slot 1 when the error came up. I removed it and put it back in slot 1 but that didnt fix the problem. In the scripts/rom/macro folder on line 65 is where the error is comming from. I did update all my folders and ran rom/update in the program.

Im not sure why it is not reconizing the attack skill. any ideas?

thanks

[xplar]

The current SVN revision is unstable. You can expect that the game might crash. We're working on it.
It is recommended that if you have trouble with the SVN update, you should try an SVN revert (to current revision).

After you update via SVN, you should not use rom/update. In fact, that is probably a bad idea. It might have some broken patterns yet.

check your profile and make sure you have your hotkeys set correctly.you could also try deleting your rom folder and redownloading from the svn. don't forget to save your profiles, waypoints, userfunctions and any other files you may have added.

[rock5]

For starters, as the bot stands now, it's not as stable as it used to be, as Administrator has already said. So expect that you wont be able to run as many clients without it crashing. The main problem targeting objects probably takes more resources now. I you have a script that mainly just kills stuff, for example, I'd expect that not to be affected. So if running the eggs script, try running fewer clients until we improve the stability.

Second, DON'T USE UPDATE.LUA. Never use update.lua after a big patch that changes addresses. It usually needs to be updated before it works again and it's usually not the highest priority. Getting the new addesses is. If you've already used "update.lua" and some of the addresses changed then do a "TortoiseSVN/Revert" on it, to restore it.

I don't think UseBagItem works at the moment so player:mount(), potion use, etc. wont work. The stuff we are working on now might eventually fix it.

[ako ito]

ok an hour ago i run 5 client and 3/5 crashing... so i will try 2 client..

[lisa]

Just an update on that addon,
I removed the monitoring whispers and it still works, So I really have no idea why it was monitoring whispers.

I am currently looking at stripping it down and getting rid of other code which isn't needed.

[rooster1620]

hello all, i am new at this so pls pardon my nabishness. i think i have all the files how they are supposed to be but i keep crashing while botting wood dailies. only have 1 client going it harvests the first node then crash report. any hints as to what i am doing wrong?.....pls help AH prices are retarded....eggs help!

[lisa]

hello all, i am new at this so pls pardon my nabishness. i think i have all the files how they are supposed to be but i keep crashing while botting wood dailies. only have 1 client going it harvests the first node then crash report. any hints as to what i am doing wrong?.....pls help AH prices are retarded....eggs help!

Still working on the crash issue with gather/harvesting.

[rooster1620]

hello all, i am new at this so pls pardon my nabishness. i think i have all the files how they are supposed to be but i keep crashing while botting wood dailies. only have 1 client going it harvests the first node then crash report. any hints as to what i am doing wrong?.....pls help AH prices are retarded....eggs help!

Still working on the crash issue with gather/harvesting.

ok thanks, sometimes its hard to track down the good info through all the crap on forums...thnx again and keep up the good work

[emmanuel04]

I have this problem when i start rom\bot. I see that it only happens with my characters over lvl 62.
I did run both SVN update on the rom folder and the "TortoiseSVN/Revert" and have also deleted my profile (and tired it using the userdefault.xml )and yet i still get the same message.

Code: Select all

The macro is currently not running. Press the start key (Delete) to begin.
You may use (End) key to stop/pause the script.
Resumed.
RoM windows size is 1920x1054, upper left corner at 8,30
Loading profile userdefault.xml
...manSr/Desktop/RomBot 2011/scripts/rom/macros.lua:65: The "Attack" skill n
eeds to be in the actionbar and have a valid hotkey. Usually one of the first 12
action keys in the bottom actionbar.


Please enter the script name to run.
Type in 'exit' (without quotes) to exit.
Script>

[ako ito]

in game press k, now go to tab 1, skill top left of screen is attack. hold left click on it and drag it to the action bar.
Also make sure that where you put the skill it has a hotkey for it.
any of these are concidered valid.
1 2 3 4 5 6 7 8 9 0 - =

[emmanuel04]

O TY that worked great.
Now I wish I could use

Code: Select all

 <onSkillCast><![CDATA[


target = player:getTarget();
   if target.Id == 103169 then
      if sendMacro("madman.Time") >= 1 then
         player:clearTarget();
         printf("Running\n")
         yrest(6000)
      end
   end  
 
player:updateBuffs()
if arg1.Name =="WARDEN_SUMMON_OAK_WALKER" then
player:rest(2);
player:cast("WARDEN_POWER_OF_THE_OAK");
player:rest(2);
player:cast("WARDEN_SUMMON_CHIRON_THE_CENTAUR");
player:rest(8);
end


player:updateBuffs()
if arg1.Name =="WARDEN_SUMMON_SPIRIT_OF_THE_OAK" then
player:rest(2);
player:cast("WARDEN_HEART_OF_THE_OAK");
player:rest(2);
player:cast("WARDEN_SUMMON_CHIRON_THE_CENTAUR");
player:rest(8);
end
   ]]></onSkillCast>

[Doggybag]

After running Rev. 647 the gold-egg bot starts farming without any problems.
Only (as you already announced) trying to run more than one client, crashes the game.

[rock5]

They should work if you've added them to your actionbar and profile and setup the profile skills hotkeys correctly.

[lisa]

Ok update to latest revision, 648 and also do a svn revert to make sure.

The crash issue should be fixed now, with the way they changed how harvesting objects works though it will still have more load on PC then it used to. So if you used to run 20 miller bots then you will probably only get 15 odd with stability. Can't do much about that.

We also missed an address if someone wants to find it.

partyMemberList_address =

Just post on here when you find it, I'll test and then update it.
I am a little tired so I might leave it for someone else to do

Obviously with that address missing party bot won't function, also just comment out the party settings in profile, or set to false.

[ako ito]

great job.. .....
thank you so much rock lisa n admin

[ako ito]

thank you so much to your time, your effort... you have a great job...